Skip to content

Add missing namespace to isnan calls #43104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Oct 27, 2023
+2 −2
Merged

Add missing namespace to isnan calls #43104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6da857e
Add missing namespace to isnan calls in PhotonMVABasedHaloTagger.cc
iarspider Oct 24, 2023
c34d549
Update Primary4DVertexValidation.cc
iarspider Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RecoEgamma/PhotonIdentification/src/PhotonMVABasedHaloTagger.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ double PhotonMVABasedHaloTagger::calculateMVA(const reco::Photon* pho,
////set all the above calculated variables as input to the MVA

const auto& vCov = lazyToolnoZS.localCovariances(*(pho->superCluster()->seed()));
double spp = (isnan(vCov[2]) ? 0. : sqrt(vCov[2]));
double spp = (std::isnan(vCov[2]) ? 0. : sqrt(vCov[2]));

///https://cmssdt.cern.ch/lxr/source/RecoEgamma/ElectronIdentification/src/ElectronMVAEstimator.cc

Expand Down
2 changes: 1 addition & 1 deletion Validation/MtdValidation/plugins/Primary4DVertexValidation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1323,7 +1323,7 @@ void Primary4DVertexValidation::analyze(const edm::Event& iEvent, const edm::Eve
unsigned int noPIDtype = 0;
if (probPi[*iTrack] == -1) {
noPIDtype = 1;
} else if (isnan(probPi[*iTrack])) {
} else if (std::isnan(probPi[*iTrack])) {
noPIDtype = 2;
} else if (probPi[*iTrack] == 1 && probK[*iTrack] == 0 && probP[*iTrack] == 0) {
noPIDtype = 3;
Expand Down