Use script_test_many_writeTotemDAQMapping.py from release if missing locally #43037

smuzaffar · 2023-10-17T13:26:47Z

This PR allows to use CalibPPS/ESProducers/test/script_test_many_writeTotemDAQMapping.py from release area if missing locally. Note that during PR tests it is not guaranteed that package CalibPPS/ESProducer will be checkout e.g. for PR cms-sw/cmsdist#8764 , unit test test_XMLToSQLiteMapping failed due to missing CalibPPS/ESProducer

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee81ff/35212/unitTests/src/CondTools/CTPPS/test/test_XMLToSQLiteMapping/testing.log

===== Test "test_XMLToSQLiteMapping" ====
Generated SQLite files
python3: can't open file '/pool/condor/dir_7825/jenkins/workspace/ib-run-pr-tests/CMSSW_13_3_X_2023-10-16-1100/src/CalibPPS/ESProducers/test/script_test_many_writeTotemDAQMapping.py': [Errno 2] No such file or directory
Failed in script_test_many_writeTotemDAQMapping.py: status 2

---> test test_XMLToSQLiteMapping had ERRORS
TestTime:72
^^^^ End Test test_XMLToSQLiteMapping ^^^^

…locally

smuzaffar · 2023-10-17T13:26:55Z

please test

cmsbuild · 2023-10-17T13:32:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43037/37218

This PR adds an extra 12KB to repository

cmsbuild · 2023-10-17T13:32:52Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

CondTools/CTPPS (db)

@perrotta, @saumyaphor4252, @consuegs, @francescobrivio can you please review it and eventually sign? Thanks.
@PonIlya, @yuanchao, @mmusich, @fabferro, @rsreds this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-10-17T17:28:51Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c3208/35223/summary.html
COMMIT: 7c5c83f
CMSSW: CMSSW_13_3_X_2023-10-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43037/35223/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test_XMLToSQLiteMapping had ERRORS

Comparison Summary

Summary:

You potentially added 3 lines to the logs
Reco comparison results: 2986 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3357400
DQMHistoTests: Total failures: 6126
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3351252
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: found differences in 1 / 48 workflows

perrotta · 2023-10-19T08:20:54Z

@smuzaffar the same kind of fix should be also implemented into CalibPPS/ESProducers/test/script_test_many_writeTotemDAQMapping.py
where test_writeTotemDAQMapping.py is searched for under $CMSSW_BASE

smuzaffar · 2023-10-19T12:36:37Z

@perrotta , I have updated script_test_many_writeTotemDAQMapping.py to not depend on CMSSW_BASE instead read the test_writeTotemDAQMapping.py from its own directory

smuzaffar · 2023-10-19T12:36:46Z

please test

cmsbuild · 2023-10-19T12:40:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43037/37273

This PR adds an extra 16KB to repository

cmsbuild · 2023-10-19T12:41:06Z

Pull request #43037 was updated. @saumyaphor4252, @consuegs, @francescobrivio, @perrotta can you please check and sign again.

cmsbuild · 2023-10-19T15:08:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c3208/35286/summary.html
COMMIT: a1ea96a
CMSSW: CMSSW_13_3_X_2023-10-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43037/35286/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 2 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3357400
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3357372
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 214 log files, 167 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2023-10-19T15:46:29Z

+1

cmsbuild · 2023-10-19T15:46:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-10-23T13:56:22Z

+1

perrotta · 2023-10-26T10:25:44Z

@smuzaffar this fix does not seem to be enough, see for example the unit test error in #43079

After having merged this fix, the test is able to retrieve the file in $CMSSW_RELEASE_BASE/src/CalibPPS/ESProducers/test/script_test_many_writeTotemDAQMapping.py but then it complains when executing this line that it is read-only:

===== Test "test_XMLToSQLiteMapping" ====
Generated SQLite files
Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_13_3_X_2023-10-25-2300/src/CalibPPS/ESProducers/test/script_test_many_writeTotemDAQMapping.py", line 32, in <module>
    with open(test_script, 'r+') as f:
OSError: [Errno 30] Read-only file system: '/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02808/el8_amd64_gcc12/cms/cmssw/CMSSW_13_3_X_2023-10-25-1100/src/CalibPPS/ESProducers/test/test_writeTotemDAQMapping.py'
Failed in script_test_many_writeTotemDAQMapping.py: status 1

---> test test_XMLToSQLiteMapping had ERRORS

I have no idea of possible further fixes, besides explicitly adding the package in case the $CMSSW_BASE/src/CalibPPS/ESProducers directory is not found, which looks however a quite inelegant solution to me.

Do you have any better idea?

smuzaffar · 2023-10-26T10:31:47Z

@perrotta , looks like unit test is reading and updating CalibPPS/ESProducers/test/test_writeTotemDAQMapping.py file. This is bad. I would suggest that unit tests should make a copy of CalibPPS/ESProducers/test/test_writeTotemDAQMapping.py and read/update that copy and run it. Copy should be made in current directory ( which will be readable/writable to test)

antoniovilela · 2023-10-29T23:19:27Z

@perrotta , looks like unit test is reading and updating CalibPPS/ESProducers/test/test_writeTotemDAQMapping.py file. This is bad. I would suggest that unit tests should make a copy of CalibPPS/ESProducers/test/test_writeTotemDAQMapping.py and read/update that copy and run it. Copy should be made in current directory ( which will be readable/writable to test)

@smuzaffar @perrotta
Hi Shahzad, Andrea,
Let's open an issue and assign to PPS, concerning this unit test?

smuzaffar · 2023-10-30T08:37:53Z

I will open a PR to fix this

smuzaffar · 2023-10-30T08:49:05Z

#43147 fixes this

perrotta · 2023-10-30T08:57:20Z

#43147 fixes this

Thank you @smuzaffar !

Use script_test_many_writeTotemDAQMapping.py from release if missing …

7c5c83f

…locally

cmsbuild added this to the CMSSW_13_3_X milestone Oct 17, 2023

cmsbuild added db-pending pending-signatures orp-pending tests-started code-checks-pending labels Oct 17, 2023

smuzaffar mentioned this pull request Oct 17, 2023

Update libunwind to v1.7.2 cms-sw/cmsdist#8764

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 17, 2023

cmsbuild added tests-rejected and removed tests-started labels Oct 17, 2023

use script directory to read test_writeTotemDAQMapping.py

a1ea96a

cmsbuild added alca-pending tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Oct 19, 2023

cmsbuild added tests-started and removed tests-pending labels Oct 19, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 19, 2023

smuzaffar mentioned this pull request Oct 19, 2023

cms-git-tools: Introduce cms-squash-topic cms-sw/cmsdist#8771

Merged

cmsbuild added tests-approved and removed tests-started labels Oct 19, 2023

cmsbuild added alca-approved fully-signed db-approved and removed alca-pending db-pending pending-signatures labels Oct 19, 2023

cmsbuild added orp-approved and removed orp-pending labels Oct 23, 2023

cmsbuild merged commit ad7d483 into cms-sw:master Oct 23, 2023

This was referenced Oct 23, 2023

Updated root to tip of branch master cms-sw/cmsdist#8777

Merged

Cleanup CICADA/CaloSummary emulation and make CICADA versions available as templated plugins #43091

Merged

perrotta mentioned this pull request Oct 26, 2023

Fix mismatch error in CTPPSRPAlignmentInfoAnalyzer #43079

Merged

smuzaffar mentioned this pull request Oct 30, 2023

Fix unittest by making a local copy of test configuration #43147

Merged

Use script_test_many_writeTotemDAQMapping.py from release if missing locally #43037

Use script_test_many_writeTotemDAQMapping.py from release if missing locally #43037

Uh oh!

Conversation

smuzaffar commented Oct 17, 2023

Uh oh!

smuzaffar commented Oct 17, 2023

Uh oh!

cmsbuild commented Oct 17, 2023

Uh oh!

cmsbuild commented Oct 17, 2023

Uh oh!

cmsbuild commented Oct 17, 2023

Unit Tests

Comparison Summary

Uh oh!

perrotta commented Oct 19, 2023

Uh oh!

smuzaffar commented Oct 19, 2023

Uh oh!

smuzaffar commented Oct 19, 2023

Uh oh!

cmsbuild commented Oct 19, 2023

Uh oh!

cmsbuild commented Oct 19, 2023

Uh oh!

cmsbuild commented Oct 19, 2023

Comparison Summary

Uh oh!

perrotta commented Oct 19, 2023

Uh oh!

cmsbuild commented Oct 19, 2023

Uh oh!

rappoccio commented Oct 23, 2023

Uh oh!

perrotta commented Oct 26, 2023

Uh oh!

smuzaffar commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoniovilela commented Oct 29, 2023

Uh oh!

smuzaffar commented Oct 30, 2023

Uh oh!

smuzaffar commented Oct 30, 2023

Uh oh!

perrotta commented Oct 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smuzaffar commented Oct 26, 2023 •

edited

Loading