Herwig lhe matching fix 12_4 #42905
Closed
Herwig lhe matching fix 12_4 #42905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_NVProfilerService_12_4_x Fix the `NVProfilerService` and `ProcessCallGraph` [12.4.x]
…tDQM_12_4_X [12.4.X] supply DQM for `SiPixelCalSingleMuonTight`
HLT menu development for `12_4_X` (8/N): HLT V1.4 of 2022
…pu-vs-cpu-monitoring-124x ECAL - Switch off online ECAL RecHit GPU vs. CPU monitoring - 12_4_X
HBHE: arrival time [ backport 12_4 ]
…on_12_4_Sept22 [12_4_X] Added protection against out-of-range BX values in EMTF unpacker blocks
…Data_124X Update input file for HLT `addOnTests` on Run-3 Data [`12_4_X`]
…-header [12.4.X] Move Phase2L1GMT private headers in to plugins dir
…4_X_Sept22 [12_4_X] Bug fix in EMTF GEM and RPC unpacker blocks
…124X [124X] Fix double counting in HepMC to G4 handoff
…nGen_Backporrt124X Revert "[124X] Fix double counting in HepMC to G4 handoff"
This change was triggered by a case where a PuttableProductResolver was filled by a Worker that produced many products, and one of the products (A) had a Ref to another product (B), and the product B was not consumed by any module (it was only accessed through the Ref). Since the putProduct() released the WaitingTaskList of the Resolver, that lead to the consumer of A to run, and that consumer dereferenced the Ref to see that B was not there. Besides scheduled modules another cases where PuttableProductResolver is used are Sources inheriting PuttableSourceBase, and TestProcessor. In these cases the products are put into the Resolvers (or left as non-produced) before launching the prefetching of the unscheduled system. Therefore in these use cases the consuming modules do not need to wait for the Resolver to be filled. After several fix attempts it seemed easiest to just use the Worker's WaitingTaskList directly in PuttableProductResolver. This approach fulfills the requirements of both Worker and Source(-like) use cases, and even simplifies the code.
…_fit_12_4 [12_4_X] Add calibration fit plot to the PPS HPTDC PCL
…PutProduct_124x [12_4_X] Release dependent modules only after the worker has finished for scheduled modules
Contributor
|
Pull request #42905 was updated. @francescobrivio, @rappoccio, @mandrenguyen, @antoniovagnerini, @mkirsano, @smuzaffar, @tjavaid, @SiewYan, @missirol, @smorovic, @fwyzard, @vlimant, @fabiocos, @miquork, @alberto-sanchez, @GurpreetSinghChahal, @makortel, @aloeliger, @antoniovilela, @cmsbuild, @civanch, @syuvivida, @perrotta, @sunilUIET, @davidlange6, @nothingface0, @saumyaphor4252, @tvami, @mdhildreth, @bsunanda, @Dr15Jones, @jfernan2, @menglu21, @emanueleusai, @emeschi, @epalencia, @simonepigazzini, @rvenditti, @bbilin, @consuegs, @mmusich, @srimanob, @AdrianoDee, @Martin-Grunewald can you please check and sign again. |
cmsbuild
added
externals-pending
and removed
reconstruction-pending
simulation-pending
dqm-pending
l1-pending
hlt-pending
core-pending
analysis-pending
alca-pending
daq-pending
db-pending
generators-pending
geometry-pending
operations-pending
pdmv-pending
upgrade-pending
xpog-pending
heterogeneous-pending
tracking
trk
labels
Contributor
|
Pull request #42905 was updated. @iarspider, @aandvalenzuela, @smuzaffar, @cmsbuild can you please check and sign again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42673 and #42732 for use in 2022 gen production. These add a new Herwig7HadronizerFilter, designed to resolve the issue of the wrong lhe events being saved with Herwig.
Should be tested with cms-sw/cmsdist#8729