Skip to content

Fix for pixel FED error imbalance in DQM plots #42872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Sep 27, 2023
Merged

Fix for pixel FED error imbalance in DQM plots #42872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
951cf6c
skip the 2nd error word for the timeout error as in the CPU code
ferencek Sep 26, 2023
708c739
store errors only for valid DetIds
ferencek Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,7 @@ namespace pixelgpudetails {
if (!((errorWord >> sipixelconstants::OMIT_ERR_shift) & sipixelconstants::OMIT_ERR_mask)) {
if constexpr (debug)
printf("...2nd errorType=29 error, skip\n");
break;
}
errorFound = true;
break;
Expand Down Expand Up @@ -323,7 +324,8 @@ namespace pixelgpudetails {
skipROC = (roc < pixelgpudetails::maxROCIndex) ? false : (errorType != 0);
if (includeErrors and skipROC) {
uint32_t rID = getErrRawID<debug>(fedId, ww, errorType, cablingMap);
err->push_back(SiPixelErrorCompact{rID, ww, errorType, fedId});
if (rID != 0xffffffff) // store errors only for valid DetIds
err->push_back(SiPixelErrorCompact{rID, ww, errorType, fedId});
continue;
}

Expand Down