Customize HLT for ECAL timing conditions record label HLT #42869
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42869/37005
|
|
A new Pull Request was created by @thomreis (Thomas Reis) for master. It involves the following packages:
@cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
mmusich
left a comment
mmusich
left a comment
There was a problem hiding this comment.
before going this way I would appreciate your thoughts on the proposal at https://its.cern.ch/jira/browse/CMSHLT-2931 instead.
| return process | ||
|
|
||
|
|
||
| def customizeHLTfor42817and42860(process): |
There was a problem hiding this comment.
| def customizeHLTfor42817and42860(process): | |
| def customizeHLTfor42869(process): |
this PR name has to be used here.
There was a problem hiding this comment.
How can one put in the PR number here before making the PR?
There was a problem hiding this comment.
you can push again after you obtain the PR number :D
|
|
||
| process = customizeHLTfor42514(process) | ||
| process = customizeHLTfor42497(process) | ||
| process = customizeHLTfor42817and42860(process) |
There was a problem hiding this comment.
| process = customizeHLTfor42817and42860(process) | |
| process = customizeHLTfor42869(process) |
this PR name has to be used here.
|
@thomreis please squash the commits to a single one. |
thomreis
force-pushed
the
ecal-timing-cond-selection-hlt-customization
branch
from
56d2dd0 to
6de7ba5
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42869/37007
|
|
Pull request #42869 was updated. @cmsbuild, @missirol, @mmusich, @Martin-Grunewald can you please check and sign again. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42869/37010
|
|
assign @cms-sw/alca-l2 |
|
assign alca |
|
New categories assigned: alca @perrotta,@consuegs,@saumyaphor4252 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
please test |
|
@cmsbuild, please abort
|
|
As discussed in between ECAL, TSG, Reco, AlCa, and PPD we will change the set of conditions such that the HLT will continue to consume the current record. This PR is therefore not needed. |
6 participants
PR description:
This PR contains a customization for the HLT to consume the ECAL time calibration and time offset records labelled "HLT" instead of the unlabelled ones.
This is needed to be able to use different conditions for the different ECAL timing algorithms at the HLT and in offline reconstruction.
The PR requires PRs #42817 and #42860 , which provide the necessary config parameters.
The GTs need to contain the records
EcalTimeOffsetConstantRcdandEcalTimeCalibConstantsRcdwith the label "HLT".