[13_2_X] Adding ZDC Unpacker to L1RawtoDigi

[mandrenguyen]

backport of #42733

[cmsbuild]

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_13_2_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Adding ZDC Unpacker to L1RawtoDigi #42733

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b2f849/34787/summary.html
COMMIT: 56ebf9b
CMSSW: CMSSW_13_2_X_2023-09-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42800/34787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3198168
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3198140
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[antoniovilela]

@matt2275 @aloeliger @mandrenguyen
Could we quickly re-run the validation here?

[matt2275]

I tested this branch and had no issues with producing an output with the zdc unpacker identical to the previous tests.

Procedure:

    cmsrel CMSSW_13_2_X_2023-09-15-1100
    cd  CMSSW_13_2_X_2023-09-15-1100/src
    cmsenv
    
    Then I added the EventFilter/L1TRawtoDigi directory from here (https://github.com/mandrenguyen/cmssw/tree/ZDCUnpacker_132X/EventFilter/L1TRawToDigi) 
    
    scram b -j 8

There were no compiler issues.

To test the zdc unpacker. I ran this program ( https://github.com/cms-sw/cmssw/blob/master/EventFilter/L1TRawToDigi/utils/unpackData-CaloStage2.py#L156) with this command ( nb, to fix an error you need to change token to label in the line I marked) :

  cmsRun unpackData-CaloStage2.py inputFiles=file:/eos/cms/store/t0streamer/Data/PhysicsCommissioning/000/373/425/run373425_ls0050_streamPhysicsCommissioning_StorageManager.dat streamer=True skipEvents=0 maxEvents=1000 valEvents=False debug=False dumpRaw=True dumpDigis=True histos=True edm=True

The program ran correctly and made an edm file identical to one I made previously to test the original PR

[aloeliger]

@antoniovilela will that suffice, or do you need @matt2275 to produce identical files to what was shown before?

[antoniovilela]

@antoniovilela will that suffice, or do you need @matt2275 to produce identical files to what was shown before?

I understand one could reproduce the tests from
#42733 (comment)

If you are happy, please sign this PR.

[aloeliger]

+l1

• Likely necessary in production as quickly as possible

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[aloeliger]

urgent

• I guess I should mark it with this

[antoniovilela]

+1