Skip to content

Conversation

@slava77
Copy link
Contributor

@slava77 slava77 commented Aug 24, 2023

extend PU Flat55To75 to 2024 workflows

extend PU Flat55To75  to 2024 workflows
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42653/36713

  • This PR adds an extra 52KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @srimanob, @cmsbuild, @AdrianoDee, @miquork, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Aug 24, 2023

test parameters:

  • workflow = 13034.0

@slava77
Copy link
Contributor Author

slava77 commented Aug 24, 2023

@cmsbuild please test

@slava77
Copy link
Contributor Author

slava77 commented Aug 24, 2023

@cmsbuild please abort test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42653/36714

  • This PR adds an extra 56KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

Pull request #42653 was updated. @bbilin, @srimanob, @cmsbuild, @AdrianoDee, @miquork, @sunilUIET can you please check and sign again.

@slava77 slava77 changed the title Update relval_steps.py extend PU Flat55To75 to 2024 workflows Aug 24, 2023
@slava77
Copy link
Contributor Author

slava77 commented Aug 24, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221eea/34464/summary.html
COMMIT: 68ef15d
CMSSW: CMSSW_13_3_X_2023-08-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42653/34464/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221eea/34464/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-221eea/34464/git-merge-result

Comparison Summary

Summary:

  • You potentially added 251 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3233 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3312525
  • DQMHistoTests: Total failures: 9513
  • DQMHistoTests: Total nulls: 13
  • DQMHistoTests: Total successes: 3302977
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.441 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 13034.0 ): 7.441 KiB SiStrip/MechanicalView
  • Checked 211 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 1 / 47 workflows

@slava77
Copy link
Contributor Author

slava77 commented Aug 24, 2023

Reco comparison results: 3233 differences found in the comparisons

as expected, changes are only in 13034.0 workflows, consistent with increased pileup.

@sunilUIET
Copy link
Contributor

+pdmv

@mmusich
Copy link
Contributor

mmusich commented Aug 28, 2023

@cms-sw/upgrade-l2 please have a look

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2c973b1 into cms-sw:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants