Fix elements_with_stride_nd when the index is outside the extent

[fwyzard]

PR description:

Extend testKernel.dev.cc with a 2D kernel test that uses large block sizes and redundant blocks.

Fix elements_with_stride_nd when the initial index is outside the extent; this fixes the issue revealed by the new test.

Also:

• add support for the AccCpuThreads accelerator;
• rename member variables for consistency;
• improve comments.

PR validation:

The new unit tests completes successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be backported to 13.0.x and later.

[fwyzard]

please test with cms-sw/cmsdist#8645

[fwyzard]

enable gpu

[fwyzard]

+heterogeneous

The updated test works locally.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42558/36576

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HeterogeneousCore/AlpakaInterface/interface/workdivision.h modified in PR(s): Adding HeterogeneousCore/AlpakaUtilities and changes into HeterogeneousCore/AlpakaInterface #40932, Porting Pixel Tracks to Alpaka [Not to Merge]  #41117, Pixel Alpaka Migration: AlpakaInterface Updates [II] #41284

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• HeterogeneousCore/AlpakaInterface (heterogeneous)

can you please review it and eventually sign? Thanks.
@makortel, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84f443/34258/summary.html
COMMIT: 938674c
CMSSW: CMSSW_13_3_X_2023-08-13-2300/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42558/34258/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3152843
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3152815
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 40118
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 40098
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[fwyzard]

type bugfix

[perrotta]

@fwyzard does this PR require that cms-sw/cmsdist#8645 is also merged?

• YES: please sign it
• NO: let retest this one without that additional cmsdist PR

[fwyzard]

@fwyzard does this PR requires that cms-sw/cmsdist#8645 is also merged?

Yes.

• YES: please sign it

I cannot sign cmsdist PRs, but if people give the rights to do so, I will :-)

• NO: let retest this one without that additional cmsdist PR

.A

[makortel]

@fwyzard does this PR requires that cms-sw/cmsdist#8645 is also merged?

Yes.

• YES: please sign it

I cannot sign cmsdist PRs, but if people give the rights to do so, I will :-)

@perrotta Did you perhaps mean the cms-sw/cmsdist#8645 should be assigned to heterogeneous (that @fwyzard could then sign)?

[perrotta]

I cannot sign cmsdist PRs, but if people give the rights to do so, I will :-)

Sorry, I am in mid-summer (supposedly holiday...) mode: I was convinced that there was a missing "heterogeneous" signature there, that why I wondered why it was not signed yet. Let merge everything at once, then

[perrotta]

+1

[fwyzard]

Thank you :-)

[makortel]

add support for the AccCpuThreads accelerator;

This statement refers specifically to the workdivision.h header, right?

[fwyzard]

add support for the AccCpuThreads accelerator;

This statement refers specifically to the workdivision.h header, right?

Yes, there is no support added to the other headers.