Skip to content

Conversation

@alintulu
Copy link
Contributor

@alintulu alintulu commented Aug 7, 2023

PR description:

This PR is to address the concern brought up in #40438 (comment). It creates a new module for gtStage2Digis, as well as every module needed to update the configuration given the initial change. The new modules are named after the original, with a suffix of Scouting (e.g. gtStage2Digis -> gtStage2DigisScouting), however please let me know if there is a more appropriate naming strategy.

PR validation:

Together with the PR #40438, it passed the runTheMatrix tests. The Cannot unpack: no FEDRawDataCollection found messages reported in the issue that started this PR are gone, however No HLT information produced is still present (an example is displayed below).

Begin processing the 1st record. Run 357735, Event 501441569, LumiSection 300 on stream 0 at 07-Aug-2023 09:18:58.116 CEST
%MSG-e triggerEventValid:  PATTriggerProducer:patTriggerScouting  07-Aug-2023 09:18:58 CEST Run: 357735 Event: 501441569
trigger::TriggerEvent product with InputTag 'hltTriggerSummaryAOD::HLT' not in event
No HLT information produced

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42490/36495

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

A new Pull Request was created by @alintulu (Adelina Lintuluoto) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

test parameters:

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

please test

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

please abort

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

enable nano

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76a35b/34133/summary.html
COMMIT: b7bde18
CMSSW: CMSSW_13_3_X_2023-08-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42490/34133/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76a35b/34133/git-merge-result

@alintulu
Copy link
Contributor Author

alintulu commented Aug 8, 2023

@perrotta looking at the log for git cms-merge-topic, it seems like there was a merge conflict (with PhysicsTools/NanoAOD/python/custom_run3scouting_cff.py) when merging to PR #40438. It's asking me to rebase, however I'm not exactly sure to what? Any ideas?

@perrotta
Copy link
Contributor

perrotta commented Aug 8, 2023

@perrotta looking at the log for git cms-merge-topic, it seems like there was a merge conflict (with PhysicsTools/NanoAOD/python/custom_run3scouting_cff.py) when merging to PR #40438. It's asking me to rebase, however I'm not exactly sure to what? Any ideas?

Yeah, when I suggested this supposed simplification I overlooked the fact that this PR does not modify the baseline CMSSW, but what is already modified by another open PR: here's the conflict, two PRs which attempt to modify the same lines of code.

This PR can be closed, sorry for the noise. Let continue with your #42484, or even better with a properly updated #40438.

@perrotta perrotta closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants