-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New gtStage2Digis module for Run-3 scouting #42490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gtStage2Digis module for Run-3 scouting #42490
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42490/36495
|
|
A new Pull Request was created by @alintulu (Adelina Lintuluoto) for master. It involves the following packages:
@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters: |
|
please test |
|
please abort |
|
enable nano |
|
please test |
|
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-76a35b/34133/summary.html This pull request cannot be automatically merged, could you please rebase it? |
Yeah, when I suggested this supposed simplification I overlooked the fact that this PR does not modify the baseline CMSSW, but what is already modified by another open PR: here's the conflict, two PRs which attempt to modify the same lines of code. This PR can be closed, sorry for the noise. Let continue with your #42484, or even better with a properly updated #40438. |
PR description:
This PR is to address the concern brought up in #40438 (comment). It creates a new module for gtStage2Digis, as well as every module needed to update the configuration given the initial change. The new modules are named after the original, with a suffix of
Scouting(e.g.gtStage2Digis->gtStage2DigisScouting), however please let me know if there is a more appropriate naming strategy.PR validation:
Together with the PR #40438, it passed the runTheMatrix tests. The
Cannot unpack: no FEDRawDataCollection foundmessages reported in the issue that started this PR are gone, howeverNo HLT information producedis still present (an example is displayed below).