Skip to content

Conversation

@nancymarinelli
Copy link
Contributor

PR description:

Minor update in Validation/RecoEgamma/plugins/PhotonValidator.cc, .h. The plot in EB of dR between PF photon candidate and PF neutral hadron candidates is now split
in two |eta| regions (<1 and >1) mainly needed for Phase2, where |eta| >1 receives contributions from the HGCAL reco

This PR superseded #42009 which is now closed

PR validation:
Test was made locally using the cmsDriver for PhaseI and PhaseII on the HggGluonfusion sample. All works fine
This PR needs to be backported to the 13_1_X series

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42309/36333

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nancymarinelli for master.

It involves the following packages:

  • Validation/RecoEgamma (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@nancymarinelli nancymarinelli changed the title Nm dqm egamma v update for13 2 x fix Split the dR plot for neutral hadrons in two eta ranges in the EB Jul 19, 2023
@emanueleusai
Copy link
Member

type egamma

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6bb195/33787/summary.html
COMMIT: 0a26299
CMSSW: CMSSW_13_3_X_2023-07-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42309/33787/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3197149
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3197053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 104.13199999999995 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 1.863 KiB EgammaV/pfPhotonValidator
  • DQMHistoSizes: changed ( 10024.0,... ): 1.855 KiB EgammaV/PhotonValidator
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

  • differences in DQM plots in EGammaV as expected from the content of the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bd46a70 into cms-sw:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants