Clean Up for Pixel Tracks - Follow-up to #41632

[AdrianoDee]

PR description:

This is a follow-up to #41632 taking into account the un-resolved comments (see here).

I took the chance also to apply the changes in the cuts suggested by @CesarBernardes (see slide 5 here). This is not strictly needed since all those parameters are tunable from the config, but I would take the chance to push it anyway here.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42304/36330

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add 2023 ProdLike workflow #42283, Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelPhase2DigiToClusterCUDA.cc modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42304/36330/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42304/36330/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42304/36331

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add 2023 ProdLike workflow #42283, Adding all geometries and the FullRecoGPU for Patatrack wfs for Phase2  #41011, Guard for No Digis for Phase2 and Patatrack NuGun #41255, Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelPhase2DigiToClusterCUDA.cc modified in PR(s): Guard for No Digis for Phase2 and Patatrack NuGun #41255

[cmsbuild]

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)
• RecoHI/HiTracking (reconstruction)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoTracker/PixelSeeding (reconstruction)
• Validation/RecoTrack (dqm)

@bbilin, @emanueleusai, @clacaputo, @mandrenguyen, @cmsbuild, @AdrianoDee, @srimanob, @pmandrik, @syuvivida, @nothingface0, @sunilUIET, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @Martin-Grunewald, @threus, @mmusich, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @dkotlins, @ferencek, @mandrenguyen, @yetkinyilmaz, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @wmtford, @ebrondol, @mtosi, @fabiocos, @jazzitup, @yenjie, @kurtejung, @gpetruc, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[AdrianoDee]

test parameters:

• enable_tests = gpu
• workflows_gpu = 14950.502, 160.502
• workflows = 12434.501, 14950.501, 160.501
• relvals_opt = -w upgrade,gpu,standard
• relvals_opt_gpu = -w upgrade,gpu,standard

[AdrianoDee]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9acfbc/33777/summary.html
COMMIT: 8903155
CMSSW: CMSSW_13_3_X_2023-07-19-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42304/33777/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3227502
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3227472
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 220 log files, 175 edm output root files, 50 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 56020
• DQMHistoTests: Total failures: 2499
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 53521
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 17 log files, 21 edm output root files, 4 DQM output files
• TriggerResults: found differences in 1 / 3 workflows

[emanueleusai]

+1

• differences in GPU are spurious

[clacaputo]

+1

[srimanob]

+Upgrade

[sunilUIET]

+pdmv

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1