Move FitWithRooFit out of bin folder to make it available for DiMuonMassBiasClient

[mmusich]

PR description:

Title says it all:

• Move the FitWithRooFit class out of Alignment/OfflineValidation/bin such that there is a header file publicly available for other classes to use (commit c55d87c)
• use it to introduce a new method in DiMuonMassBiasClient to use one of the models available in FitWithRooFit, though the options is for now not active by default (commit 267ef5a)

No changes expected.

PR validation:

scram b runtests use-ibeos runs fine.
Also I've privately run the tests configuration files in DQMOffline/Alignment to run on 2023C data and obtained the fits available here .

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, possibly to be backported for 2023 data-taking

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42051/36030

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/OfflineValidation/bin/Zmumumerge.cc modified in PR(s): Nm dqm egamma v update for13 1 x #41987
  • File DQMOffline/Alignment/interface/DiMuonMassBiasClient.h modified in PR(s): Nm dqm egamma v update for13 1 x #41987
  • File DQMOffline/Alignment/src/DiMuonMassBiasClient.cc modified in PR(s): Nm dqm egamma v update for13 1 x #41987

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• DQMOffline/Alignment (dqm)

@nothingface0, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @rociovilar, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-493fb0/33337/summary.html
COMMIT: 267ef5a
CMSSW: CMSSW_13_2_X_2023-06-22-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42051/33337/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200239
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

@cms-sw/alca-l2 @cms-sw/dqm-l2 a kind ping on this one

[emanueleusai]

+1

[francescobrivio]

+1

• PR according to description
• tests clean

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1