Update Phase-2 L1T Correlator code to l1ct-125x-v1.16

[gpetruc]

PR description:

This PR ports to the CMSSW master branch two small updates to the correlator trigger code, for serializing and de-serializing electron objects in GT format (for GT emulator usage), and producing pattern files for integration tests (for correlator internal CI, not run in production)

Code is from @cerminar

The corresponding PR to the L1T Phase-2 integration branch is cms-l1t-offline#1066 for @aloeliger

PR validation:

Tested on CMSSW_13_2_X_2023-05-09-2300 with runTheMatrix.py -l 23234.0 and L1Trigger/Phase2L1ParticleFlow/test/make_l1ct_binaryFiles_cfg.py

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41613/35503

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/L1TParticleFlow/interface/gt_datatypes.h modified in PR(s): Retrained L1 Tau Trigger Integration #41492
  • File L1Trigger/Phase2L1ParticleFlow/python/l1ctLayer2EG_cff.py modified in PR(s): Phase-2 L1T e/g: new Composite Electron ID #41290

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for master.

It involves the following packages:

• DataFormats/L1TParticleFlow (upgrade, l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[gpetruc]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1db14a/32537/summary.html
COMMIT: 5c09c28
CMSSW: CMSSW_13_2_X_2023-05-10-1200/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41613/32537/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
• 138.1138.1_PromptCosmics2021/step2_PromptCosmics2021.log
• 136.9136.9_RunDoubleMuon2016C/step2_RunDoubleMuon2016C.log

Expand to see more relval errors ...

• 139.001
• 138.5
• 140.003
• 140.005
• 140.002
• 140.006
• 140.009
• 140.008
• 140.026
• 140.042
• 140.54
• 140.61
• 1325.5
• 1001.2
• 1002.4
• 11024.6
• 11834.19
• 11834.0
• 11846.0
• 20834.0
• 20834.9
• 21034.114
• 21034.999
• 21034.99
• 23634.5
• 23834.99

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460805
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[gpetruc]

I really can't see how this PR can break any matrix workflow that is not phase-2, so I'd guess the test failures were either from some technical issue or a problem with the underlying IB in which the test was run.
I can re-trigger them, but to save some energy perhaps I can wait until you've had a look at the code in case you have code quality issues to fix

[gpetruc]

please test
(retrying)

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1db14a/32585/summary.html
COMMIT: 5c09c28
CMSSW: CMSSW_13_2_X_2023-05-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41613/32585/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[aloeliger]

The output of a lot of the job doesn't show any errors even. This is potentially a network/job management issue, not an issue with the PR itself?

[aloeliger]

Absent any better ideas, I am going to try this again just to check. Other PRs are passing their tests, so I don't think any systemic issues should be present.

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1db14a/32597/summary.html
COMMIT: 5c09c28
CMSSW: CMSSW_13_2_X_2023-05-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41613/32597/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[aloeliger]

please test with #41647

whoops

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1db14a/32598/summary.html
COMMIT: 5c09c28
CMSSW: CMSSW_13_2_X_2023-05-12-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41613/32598/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3461906
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3461884
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[AdrianoDee]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1