L1T Phase 2: correlator-to-GT interface for jets and MHT

[thesps]

PR description:

This PR improves and fixes the handoff of emulated jets and MHT collections from phase 2 L1T correlator to global trigger for their emulation.

• hardware correlator produces jets in an internal format and send them in a different agreed format. Now both are made accessible and more explicitly named
• the MHT emulator was doing some incorrect decoding of the correlator jets, then incorrect encoding of the MHT for GT, that are both now fixed
• MHT in the L1TPFJetsTask was not consuming the correct collection for proper emulation of the L1T hardware, now fixed

PR validation:

These changes have been developed and studied in the context of the Phase 2 Global Trigger emulation and validation against the previously not-emulated Menu workflow by the L1T software team.

@aloeliger

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41590/35476

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DataFormats/L1TParticleFlow/src/classes_def.xml modified in PR(s): Retrained L1 Tau Trigger Integration #41492, Phase-2 L1T e/g: new Composite Electron ID #41290

[cmsbuild]

A new Pull Request was created by @thesps (Sioni Summers) for master.

It involves the following packages:

• DataFormats/L1TParticleFlow (upgrade, l1)
• L1Trigger/Phase2L1ParticleFlow (upgrade, l1)

@epalencia, @cmsbuild, @AdrianoDee, @srimanob, @aloeliger, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37fb87/32496/summary.html
COMMIT: 41ccbe2
CMSSW: CMSSW_13_2_X_2023-05-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41590/32496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460805
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[AdrianoDee]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1