bug fix for DBG IB: use correct variable name #41549

smuzaffar · 2023-05-05T07:09:17Z

This fixes the DBG build error

  CMSSW_13_2_DBG_X_2023-05-04-2300/src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalMixRotatedLayer.cc:406:61: error: 'cassett0' was not declared in this scope; did you mean 'cassette0'?
   406 |                                       << cassette << ":" << cassett0 << " Shift " << cshift.first << ":"
      |                                                             ^~~~~~~~
      |                                                             cassette0
  CMSSW_13_2_DBG_X_2023-05-04-2300/src/Geometry/HGCalCommonData/plugins/dd4hep/DDHGCalMixRotatedLayer.cc:399:13: warning: unused variable 'cassette0' [-Wunused-variable]
   399 |         int cassette0 = HGCalCassette::cassetteType(2, 1, cassette);  //

smuzaffar · 2023-05-05T07:09:26Z

please test

cmsbuild · 2023-05-05T07:18:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41549/35423

This PR adds an extra 20KB to repository

cmsbuild · 2023-05-05T07:18:38Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2023-05-05T09:16:55Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f509e/32407/summary.html
COMMIT: 9080f98
CMSSW: CMSSW_13_1_X_2023-05-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f509e/32407/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f509e/32407/git-merge-result

RelVals

136.8311

----- Begin Fatal Exception 05-May-2023 10:30:13 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 05-May-2023 10:30:14 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 05-May-2023 10:30:14 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 05-May-2023 10:33:21 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 05-May-2023 10:34:50 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_data_GRun

----- Begin Fatal Exception 05-May-2023 10:30:34 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32407/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-05-04-2300/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_data_GRun
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_data_GRun

smuzaffar · 2023-05-05T12:35:56Z

please test

cmsbuild · 2023-05-05T15:11:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f509e/32418/summary.html
COMMIT: 9080f98
CMSSW: CMSSW_13_2_X_2023-05-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41549/32418/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3460836
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3460808
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

civanch · 2023-05-05T15:16:32Z

+1

perrotta · 2023-05-05T16:18:10Z

+1

perrotta · 2023-05-05T16:21:39Z

merge
(quite obvious fix)

bug fix for DBG IB: use correct variable name

9080f98

cmsbuild added this to the CMSSW_13_2_X milestone May 5, 2023

cmsbuild added geometry-pending pending-signatures orp-pending tests-started upgrade-pending code-checks-pending labels May 5, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 5, 2023

cmsbuild added tests-rejected and removed tests-started labels May 5, 2023

cmsbuild added tests-started and removed tests-rejected labels May 5, 2023

cmsbuild added tests-approved and removed tests-started labels May 5, 2023

cmsbuild added geometry-approved and removed geometry-pending labels May 5, 2023

cmsbuild added orp-approved and removed orp-pending labels May 5, 2023

cmsbuild merged commit 5d380d3 into cms-sw:master May 5, 2023

cmsbuild mentioned this pull request May 6, 2023

Root update master 20230505 cms-sw/cmsdist#8498

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug fix for DBG IB: use correct variable name #41549

bug fix for DBG IB: use correct variable name #41549

Uh oh!

smuzaffar commented May 5, 2023

Uh oh!

smuzaffar commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

smuzaffar commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

civanch commented May 5, 2023

Uh oh!

perrotta commented May 5, 2023

Uh oh!

perrotta commented May 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bug fix for DBG IB: use correct variable name #41549

bug fix for DBG IB: use correct variable name #41549

Uh oh!

Conversation

smuzaffar commented May 5, 2023

Uh oh!

smuzaffar commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

RelVals

RelVals-INPUT

AddOn Tests

Uh oh!

smuzaffar commented May 5, 2023

Uh oh!

cmsbuild commented May 5, 2023

Comparison Summary

Uh oh!

civanch commented May 5, 2023

Uh oh!

perrotta commented May 5, 2023

Uh oh!

perrotta commented May 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants