Add flag to drop quality of low-pt TkMuons without an SA match #41546

epalencia · 2023-05-04T17:03:01Z

This PR includes a flag to duplicate the tkMuonGMT collection which degrades the quality flag of those muons without an associated SA muon. This is a temporary fix until we re-optimize the ID to further control rate.

The corresponding PR in the cms-l1t-offline IB is cms-l1t-offline#1109

(cherry picked from commit fc72a1d)

cmsbuild · 2023-05-04T17:11:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41546/35418

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): implement fw-based Phase2 EG standalone barrel #41224

cmsbuild · 2023-05-04T17:11:39Z

A new Pull Request was created by @epalencia (Enrique Palencia Cortezon) for master.

It involves the following packages:

L1Trigger/Configuration (l1)
L1Trigger/Phase2L1GMT (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

epalencia · 2023-05-04T17:12:27Z

Please test

cmsbuild · 2023-05-04T18:40:36Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b299d/32385/summary.html
COMMIT: 56a81ec
CMSSW: CMSSW_13_1_X_2023-05-04-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41546/32385/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b299d/32385/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b299d/32385/git-merge-result

RelVals

23700.0

----- Begin Fatal Exception 04-May-2023 20:14:58 CEST-----------------------
An exception of category 'InsertFailure' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module Phase2L1TGMTFilter/'l1tTkMuonsGmtLowPtFix'
Exception Message:
Illegal attempt to 'put' an unregistered product.
No product is registered for
  product friendly class name: 'l1tTrackerMuons'
  module label:                'l1tTkMuonsGmtLowPtFix'
  product instance name:       ''
  process name:                'HLT'
The following data products are registered for production by l1tTkMuonsGmtLowPtFix:
Branch Type = Event
Process Name = HLT
ModuleLabel = l1tTkMuonsGmtLowPtFix
Branch ID = 2528667444
Class Name = std::vector<l1t::TrackerMuon>
Friendly Class Name = l1tTrackerMuons
Product Instance Name = l1tTkMuonsGmtLowPtFix
-----

To correct the problem:
   1) make sure the proper 'produce' call is being made in the module's constructor,
   2) if 'produce' exists and uses a product instance name make sure that same name is used during the 'put' call.
----- End Fatal Exception -------------------------------------------------

23696.0

----- Begin Fatal Exception 04-May-2023 20:15:25 CEST-----------------------
An exception of category 'InsertFailure' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module Phase2L1TGMTFilter/'l1tTkMuonsGmtLowPtFix'
Exception Message:
Illegal attempt to 'put' an unregistered product.
No product is registered for
  product friendly class name: 'l1tTrackerMuons'
  module label:                'l1tTkMuonsGmtLowPtFix'
  product instance name:       ''
  process name:                'HLT'
The following data products are registered for production by l1tTkMuonsGmtLowPtFix:
Branch Type = Event
Process Name = HLT
ModuleLabel = l1tTkMuonsGmtLowPtFix
Branch ID = 2528667444
Class Name = std::vector<l1t::TrackerMuon>
Friendly Class Name = l1tTrackerMuons
Product Instance Name = l1tTkMuonsGmtLowPtFix
-----

To correct the problem:
   1) make sure the proper 'produce' call is being made in the module's constructor,
   2) if 'produce' exists and uses a product instance name make sure that same name is used during the 'put' call.
----- End Fatal Exception -------------------------------------------------

23634.0

----- Begin Fatal Exception 04-May-2023 20:18:01 CEST-----------------------
An exception of category 'InsertFailure' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Calling method for module Phase2L1TGMTFilter/'l1tTkMuonsGmtLowPtFix'
Exception Message:
Illegal attempt to 'put' an unregistered product.
No product is registered for
  product friendly class name: 'l1tTrackerMuons'
  module label:                'l1tTkMuonsGmtLowPtFix'
  product instance name:       ''
  process name:                'HLT'
The following data products are registered for production by l1tTkMuonsGmtLowPtFix:
Branch Type = Event
Process Name = HLT
ModuleLabel = l1tTkMuonsGmtLowPtFix
Branch ID = 2528667444
Class Name = std::vector<l1t::TrackerMuon>
Friendly Class Name = l1tTrackerMuons
Product Instance Name = l1tTkMuonsGmtLowPtFix
-----

To correct the problem:
   1) make sure the proper 'produce' call is being made in the module's constructor,
   2) if 'produce' exists and uses a product instance name make sure that same name is used during the 'put' call.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

20834.020834.0_TTbar_14TeV+2026D88/step2_TTbar_14TeV+2026D88.log
20834.520834.5_TTbar_14TeV+2026D88_pixelTrackingOnly/step2_TTbar_14TeV+2026D88_pixelTrackingOnly.log
20834.920834.9_TTbar_14TeV+2026D88_vectorHits/step2_TTbar_14TeV+2026D88_vectorHits.log

Expand to see more relval errors ...

Fix to l1t-1109_v3

cmsbuild · 2023-05-08T19:39:31Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41546/35474

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): implement fw-based Phase2 EG standalone barrel #41224

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41546/35474/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41546/35474/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-05-12T10:29:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41546/35530

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/Configuration/python/SimL1Emulator_cff.py modified in PR(s): implement fw-based Phase2 EG standalone barrel #41224

cmsbuild · 2023-05-12T10:29:27Z

Pull request #41546 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again.

epalencia · 2023-05-12T10:31:29Z

Please test

cmsbuild · 2023-05-12T14:43:08Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1b299d/32589/summary.html
COMMIT: a559c5a
CMSSW: CMSSW_13_2_X_2023-05-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41546/32589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 10 lines to the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3461906
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3461881
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

epalencia · 2023-05-12T14:46:44Z

+l1

cmsbuild · 2023-05-12T14:47:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-05-12T16:59:39Z

+1

Low-pt muon fix

56a81ec

(cherry picked from commit fc72a1d)

cmsbuild added this to the CMSSW_13_2_X milestone May 4, 2023

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 4, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 4, 2023

cmsbuild added tests-started and removed tests-pending labels May 4, 2023

Merged refs/pull/41546/head from repository cms-sw with cms-merge-topic

ff78706

cmsbuild added tests-rejected and removed tests-started labels May 4, 2023

folguera and others added 3 commits May 8, 2023 18:40

fix to avoid failing of automtated tests

cd0de40

remove commented line

996d361

Merge pull request #2 from folguera/FixTo_epalencia_l1t-1109_v3

53419b9

Fix to l1t-1109_v3

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels May 8, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 8, 2023

folguera added 2 commits May 9, 2023 10:07

fix for low-pt fix

a1fe4ad

Merge branch 'l1t-1109_v3' into fix_epalencia_l1t-1109_v3

ab707cd

cmsbuild added l1-pending pending-signatures tests-pending code-checks-pending and removed l1-approved fully-signed tests-approved code-checks-approved labels May 12, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels May 12, 2023

cmsbuild added tests-started and removed tests-pending labels May 12, 2023

cmsbuild added tests-approved and removed tests-started labels May 12, 2023

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels May 12, 2023

cmsbuild added orp-approved and removed orp-pending labels May 12, 2023

cmsbuild merged commit ada3617 into cms-sw:master May 12, 2023

cmsbuild mentioned this pull request May 12, 2023

Updates to L1 tracking (improved use of stub bend etc.) #40335

Merged

artlbv referenced this pull request in p2l1pfp/FastPUPPI Jul 6, 2023

Add btag and muons to scouting ntuple, re-run tkmuons on mu ntuple

0465c37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add flag to drop quality of low-pt TkMuons without an SA match #41546

Add flag to drop quality of low-pt TkMuons without an SA match #41546

Uh oh!

epalencia commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

Uh oh!

epalencia commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

Uh oh!

cmsbuild commented May 8, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

epalencia commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

epalencia commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

rappoccio commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add flag to drop quality of low-pt TkMuons without an SA match #41546

Add flag to drop quality of low-pt TkMuons without an SA match #41546

Uh oh!

Conversation

epalencia commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

Uh oh!

epalencia commented May 4, 2023

Uh oh!

cmsbuild commented May 4, 2023

RelVals

RelVals-INPUT

Uh oh!

cmsbuild commented May 8, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

epalencia commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Comparison Summary

Uh oh!

epalencia commented May 12, 2023

Uh oh!

cmsbuild commented May 12, 2023

Uh oh!

rappoccio commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants