Add ParticleNet info to taus in NanoAOD #41333

mbluj · 2023-04-13T12:31:08Z

PR description:

This PR adds ParticleNet info (extended in #40745) to taus stored in NanoAOD. The additional information are as follows:

ParticleNet discriminators vs jets, electrons and muons,
decay mode corresponding with the ParticleNet tau node with the highest score,
correction for tau pt,
charge assignment confidence (signed),
ParticleNet scores for individual decay-modes (normalised to the sum of the scores for all tau nodes).

In addition to adding the above information to already existing taus reconstructed with the HPS algorithm (and passing the loosest WP of at least one of its discriminants vs jets) "recovery" taus are added which correspond with CHSAK4 jets with ParticleNet discriminant vs jets passing WP (>0.05) with an efficiency of ~97% for genuine taus. Also HPS taus passing this WP of ParticleNet vs jet discriminant and not passing other discriminants vs jets are stored (however their fraction is at permille level).

The ParticleNet information and "recovery" taus are added with a new "hybrid tau" producer which matches CHSAK4 jets with ParticleNet taggers with HPS-taus. The producer can be in principle used also as part of miniAOD sequences.

Backport of this PR is planned to CMSSW_13_0 series.

PR validation:

Tested successfully with custom NanoAOD workflows based on standard NanoAOD setups for RunIISummer20UL18NanoAODv11 and Run3Summer22NanoAODv11 as well as with the "limited" set of matrix tests.

mbluj · 2023-04-13T12:34:55Z

FYI, @kandrosov @scooperstein

cmsbuild · 2023-04-13T12:37:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41333/35160

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275

cmsbuild · 2023-04-13T12:38:19Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)

@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @AnnikaStein, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

PhysicsTools/NanoAOD/python/nano_cff.py

PhysicsTools/NanoAOD/python/taus_cff.py

cmsbuild · 2023-04-14T16:11:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41333/35175

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275
- File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167, Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275

mandrenguyen · 2023-04-17T14:27:21Z

abort test

mandrenguyen · 2023-04-17T14:28:29Z

enable nano

mandrenguyen · 2023-04-17T14:29:35Z

please test

cmsbuild · 2023-04-17T17:11:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f2ba3e/32002/summary.html
COMMIT: 663d2a5
CMSSW: CMSSW_13_1_X_2023-04-17-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41333/32002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 16 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 116 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3459609
DQMHistoTests: Total failures: 351
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3459236
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 21.997999999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 2.760 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): 1.339 KiB Physics/NanoAODDQM
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 38 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 400 differences found in the comparisons
DQMHistoTests: Total files compared: 12
DQMHistoTests: Total histograms compared: 12072
DQMHistoTests: Total failures: 505
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 11567
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 23.254999999999995 KiB( 11 files compared)
DQMHistoSizes: changed ( 2500.311,... ): 2.760 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.331,... ): 1.339 KiB Physics/NanoAODDQM
Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.377	2.333	0.044 ( +1.9% )	5.51	5.62	-1.9%	1.468	1.430
2500.311	2.487	2.440	0.047 ( +1.9% )	4.93	5.09	-3.1%	1.843	1.790
2500.312	2.437	2.391	0.046 ( +1.9% )	5.12	5.24	-2.3%	1.841	1.780
2500.33	1.206	1.172	0.035 ( +3.0% )	10.47	10.43	+0.4%	1.662	1.491
2500.331	1.550	1.508	0.042 ( +2.8% )	5.64	5.75	-1.9%	1.826	1.659
2500.332	1.444	1.409	0.034 ( +2.4% )	8.13	8.16	-0.4%	1.861	1.604
2500.401	2.184	2.137	0.047 ( +2.2% )	5.31	10.38	-48.8%	1.323	1.110
2500.501	1.768	1.710	0.059 ( +3.4% )	8.94	16.54	-45.9%	1.231	1.048
2500.511	1.162	1.122	0.040 ( +3.5% )	4.39	31.14	-85.9%	1.533	1.289
2500.5111	1.520	1.477	0.043 ( +2.9% )	3.85	18.65	-79.4%	1.585	1.337
2500.601	2.049	2.038	0.011 ( +0.5% )	12.63	12.57	+0.5%	1.122	1.093

mbluj · 2023-04-24T09:56:02Z

Hello,
are there any pending issues in this PR? If so, I will be happy to fix them, otherwise it will be good that this PR is approved, so that I can prepare its backport to 13_0.

simonepigazzini · 2023-04-24T12:19:56Z

+1

simonepigazzini · 2023-04-24T12:20:13Z

@mbluj please go ahead with the backport

mandrenguyen · 2023-04-27T13:58:01Z

+1

cmsbuild · 2023-04-27T13:58:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2023-04-27T13:58:27Z

type tau

rappoccio · 2023-04-27T16:33:48Z

+1

mbluj added 9 commits April 4, 2023 13:52

initial version of tau producer from HPS and PNet

d1eced9

Add fillDescriptions

157178d

Make selection configurable

3ce9150

Add genJet matching

d6da363

Use uncorrected jets to build recovery taus

d0d5100

Small addons and cleaning

05dd9f5

Simplified tau content and other small updates

ba5a1c4

Add PNet info to taus

a745024

Add tau PNEt variables to DQM

ae949e1

cmsbuild added this to the CMSSW_13_1_X milestone Apr 13, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Apr 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 13, 2023

simonepigazzini reviewed Apr 13, 2023

View reviewed changes

PhysicsTools/NanoAOD/python/nano_cff.py Show resolved Hide resolved

kandrosov reviewed Apr 13, 2023

View reviewed changes

PhysicsTools/NanoAOD/python/taus_cff.py Show resolved Hide resolved

PhysicsTools/NanoAOD/python/taus_cff.py Show resolved Hide resolved

cmsbuild mentioned this pull request Apr 14, 2023

Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275

Merged

Store charge assignment confidence and tau decay mode scores

663d2a5

cmsbuild added code-checks-pending and removed code-checks-approved labels Apr 14, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2023

cmsbuild added tests-pending and removed tests-started labels Apr 17, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 17, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 17, 2023

cmsbuild added xpog-approved and removed xpog-pending labels Apr 24, 2023

mbluj mentioned this pull request Apr 24, 2023

Add ParticleNet info to taus in NanoAOD [13_0_X] #41394

Merged

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Apr 27, 2023

cmsbuild added the tau label Apr 27, 2023

cmsbuild added orp-approved and removed orp-pending labels Apr 27, 2023

cmsbuild merged commit b0bd03f into cms-sw:master Apr 27, 2023

cmsbuild mentioned this pull request Apr 28, 2023

Displaced regional tracking iteration #40643

Merged

makortel mentioned this pull request Feb 23, 2024

Erase from correct vector in PATTauHybridProducer #44067

Merged

Add ParticleNet info to taus in NanoAOD #41333

Add ParticleNet info to taus in NanoAOD #41333

Uh oh!

Conversation

mbluj commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

mbluj commented Apr 13, 2023

Uh oh!

cmsbuild commented Apr 13, 2023

Uh oh!

cmsbuild commented Apr 13, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Apr 14, 2023

Uh oh!

mandrenguyen commented Apr 17, 2023

Uh oh!

mandrenguyen commented Apr 17, 2023

Uh oh!

mandrenguyen commented Apr 17, 2023

Uh oh!

cmsbuild commented Apr 17, 2023

Comparison Summary

NANO Comparison Summary

Uh oh!

mbluj commented Apr 24, 2023

Uh oh!

simonepigazzini commented Apr 24, 2023

Uh oh!

simonepigazzini commented Apr 24, 2023

Uh oh!

mandrenguyen commented Apr 27, 2023

Uh oh!

cmsbuild commented Apr 27, 2023

Uh oh!

mandrenguyen commented Apr 27, 2023

Uh oh!

rappoccio commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mbluj commented Apr 13, 2023 •

edited

Loading