Skip to content

Conversation

@swagata87
Copy link
Contributor

@swagata87 swagata87 commented Mar 29, 2023

PR description:

This PR is mostly meant for clean up. No physics change expected.
It cleans up 2 things:

  1. Phase2 EGM HLT moved from TICL V3 to V4 some time ago ([EGM HLT@Phase2] Move to TICL v4 #39820). But some remnants of TICL V3 had remained in EGM configs, which I did not notice before. Removing them now.
  2. Removing the obsolete and unmaintainable config RecoEgamma/EgammaHLTProducers/python/HLTEgPhaseIITestSequence_cff.py. It was useful when it was introduced (in HGCal ID variables #32519), as it allowed to test Phase2 specific code which was being used only in HLT, which was otherwise not testable as the Phase2 HLT menu was not part of CMSSW at that time. Now that we have the Phase2 HLT menu in release, there is no point of having this additional Egamma Phase2 HLT config, which anyway became obsolete very quickly.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41217/34931

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoEgamma/EgammaHLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@beaucero, @Sam-Harper, @HuguesBrun, @silviodonato, @jainshilpi, @SohamBhattacharya, @Prasant1993, @Fedespring, @lgray, @Martin-Grunewald, @missirol, @sobhatta, @afiqaize, @wrtabb, @a-kapoor, @sameasy, @valsdav, @varuns23, @cericeci, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d8266/31670/summary.html
COMMIT: a93e2cb
CMSSW: CMSSW_13_1_X_2023-03-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41217/31670/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially added 22 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3554205
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

  • cleanup PR related to Phase-2 HLT
  • unit test error most likely unrelated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit b2fcee8 into cms-sw:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants