-
Notifications
You must be signed in to change notification settings - Fork 4.6k
[EGM] Remove obsolete Phase2 configs #41217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41217/34931
|
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test test-das-selected-lumis had ERRORS Comparison SummarySummary:
|
|
+hlt
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
merge |
PR description:
This PR is mostly meant for clean up. No physics change expected.
It cleans up 2 things:
RecoEgamma/EgammaHLTProducers/python/HLTEgPhaseIITestSequence_cff.py. It was useful when it was introduced (in HGCal ID variables #32519), as it allowed to test Phase2 specific code which was being used only in HLT, which was otherwise not testable as the Phase2 HLT menu was not part of CMSSW at that time. Now that we have the Phase2 HLT menu in release, there is no point of having this additional Egamma Phase2 HLT config, which anyway became obsolete very quickly.