Added ShutdownSignal entry to JobReport #41201

Dr15Jones · 2023-03-27T20:30:49Z

PR description:

If a job was told by an external signal to shutdown early we not record that info into the FrameworkJobReport.
Also added a log message when the signal occurs.

PR validation:

Code compiles and framework unit tests pass.

cmsbuild · 2023-03-27T20:39:07Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34897

This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34897/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34897/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

If a job was told by an external signal to shutdown early we not record that info into the FrameworkJobReport.

Dr15Jones · 2023-03-27T20:40:55Z

please test

cmsbuild · 2023-03-27T20:48:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34898

This PR adds an extra 44KB to repository

cmsbuild · 2023-03-27T20:48:39Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework (core)
FWCore/MessageLogger (core)

@makortel, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

makortel · 2023-03-27T20:57:36Z

Would there be a feasible way to add a test for it? I found makeSignals that, in principle, could be used to raise a signal

cmssw/FWCore/MessageService/test/makeSignals.cc

Lines 40 to 46 in 63f929c

    
           #ifdef RAISE_SEGV 
        
                 raise(SIGSEGV); 
        
           #endif 
        
           #ifdef RAISE_USR2 
        
                 raise(SIGUSR2); 
        
           #endif

(although by it currently raises SIGSEGV)

cmsbuild · 2023-03-28T01:37:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f904/31627/summary.html
COMMIT: b3fdce0
CMSSW: CMSSW_13_1_X_2023-03-27-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41201/31627/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f904/31627/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f904/31627/git-merge-result

Comparison Summary

Summary:

You potentially removed 8 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 135 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554236
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554209
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -2.9879999999999995 KiB( 48 files compared)
DQMHistoSizes: changed ( 11834.0,... ): -0.360 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): -0.234 KiB Physics/NanoAODDQM
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

cmsbuild · 2023-03-29T20:34:13Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34945

This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34945/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34945/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

FWCore/Services/test/SignallingAnalyzer.cc

cmsbuild · 2023-03-30T16:33:55Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41201/34960

This PR adds an extra 48KB to repository

Dr15Jones · 2023-03-30T16:34:05Z

please test

cmsbuild · 2023-03-30T16:34:24Z

Pull request #41201 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

cmsbuild · 2023-03-30T19:15:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12f904/31696/summary.html
COMMIT: e006f7b
CMSSW: CMSSW_13_1_X_2023-03-30-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41201/31696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554236
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554214
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

makortel · 2023-03-30T21:44:09Z

+1

cmsbuild · 2023-03-30T21:44:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-31T07:42:32Z

+1

cmsbuild added this to the CMSSW_13_1_X milestone Mar 27, 2023

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 27, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 27, 2023

Added ShutdownSignal entry to JobReport

b3fdce0

If a job was told by an external signal to shutdown early we not record that info into the FrameworkJobReport.

Dr15Jones force-pushed the jobReportShutdownSignal branch from 5ca5072 to b3fdce0 Compare March 27, 2023 20:40

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 27, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 27, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2023

cmsbuild added tests-approved tests-pending code-checks-pending and removed tests-started tests-approved code-checks-approved labels Mar 28, 2023

cmsbuild removed the code-checks-pending label Mar 29, 2023

makortel reviewed Mar 30, 2023

View reviewed changes

FWCore/Services/test/SignallingAnalyzer.cc Show resolved Hide resolved

Add signal message unit test

e006f7b

Dr15Jones force-pushed the jobReportShutdownSignal branch from 59973e8 to e006f7b Compare March 30, 2023 16:27

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 30, 2023

cmsbuild added tests-started code-checks-approved and removed tests-pending code-checks-pending labels Mar 30, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 30, 2023

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Mar 30, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 31, 2023

cmsbuild merged commit b1009ea into cms-sw:master Mar 31, 2023

Dr15Jones deleted the jobReportShutdownSignal branch March 31, 2023 13:48

makortel mentioned this pull request Mar 31, 2023

Maintenance tasks of week 13 cms-sw/framework-team#520

Closed

1 task

cmsbuild mentioned this pull request Mar 31, 2023

Fix build failures in DBG_X after #41174 #41243

Closed

Added ShutdownSignal entry to JobReport #41201

Added ShutdownSignal entry to JobReport #41201

Uh oh!

Conversation

Dr15Jones commented Mar 27, 2023

PR description:

PR validation:

Uh oh!

cmsbuild commented Mar 27, 2023

Uh oh!

Dr15Jones commented Mar 27, 2023

Uh oh!

cmsbuild commented Mar 27, 2023

Uh oh!

cmsbuild commented Mar 27, 2023

Uh oh!

makortel commented Mar 27, 2023

Uh oh!

cmsbuild commented Mar 28, 2023

Comparison Summary

Uh oh!

cmsbuild commented Mar 29, 2023

Uh oh!

Uh oh!

cmsbuild commented Mar 30, 2023

Uh oh!

Dr15Jones commented Mar 30, 2023

Uh oh!

cmsbuild commented Mar 30, 2023

Uh oh!

cmsbuild commented Mar 30, 2023

Comparison Summary

Uh oh!

makortel commented Mar 30, 2023

Uh oh!

cmsbuild commented Mar 30, 2023

Uh oh!

perrotta commented Mar 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants