Fix build failure in DBG_X #41169

iarspider · 2023-03-24T08:14:46Z

PR description:

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc11/CMSSW_13_1_DBG_X_2023-03-23-2300/Geometry/HGCalCommonData

/data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc: In static member function 'static std::vector<std::pair<double, double> > HGCalWaferMask::waferXY(int, int, int, double, double, double, double)':
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1245:118: error: expected ';' before ')' token
  1245 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1256:118: error: expected ';' before ')' token
  1256 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1266:118: error: expected ';' before ')' token
  1266 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1281:118: error: expected ';' before ')' token
  1281 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1296:118: error: expected ';' before ')' token
  1296 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1311:118: error: expected ';' before ')' token
  1311 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1326:118: error: expected ';' before ')' token
  1326 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1341:118: error: expected ';' before ')' token
  1341 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  /data/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/05d62365f17d9d2cecbb9853ed8b8cf3/opt/cmssw/el8_amd64_gcc11/cms/cmssw/CMSSW_13_1_DBG_X_2023-03-23-2300/src/Geometry/HGCalCommonData/src/HGCalWaferMask.cc:1356:118: error: expected ';' before ')' token
  1356 |       edm::LogVerbatim("HGCalGeom") << k << ":" << np[orient][k] << ":" << dx[np[orient][k]] + offsetx[np[orient][k]])<< ":"
      |                                                                                                                      ^
      |                                                                                                                      ;
  gmake: *** [tmp/el8_amd64_gcc11/src/Geometry/HGCalCommonData/src/GeometryHGCalCommonData/HGCalWaferMask.cc.o] Error 1

PR validation:

iarspider · 2023-03-24T08:15:00Z

please test

iarspider · 2023-03-24T08:15:14Z

type bug-fix

cmsbuild · 2023-03-24T08:23:28Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41169/34843

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalWaferMask.cc modified in PR(s): Add HCAL LLP Jet Skim config #41111

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41169/34843/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41169/34843/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

smuzaffar · 2023-03-24T08:26:56Z

this was introduced in #41048 and "Static Check" were failed https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c34ee/31266/summary.html . I think bot should mark PR tests as failed if "Static checks" failed to build

cmsbuild · 2023-03-24T08:34:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41169/34844

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/HGCalCommonData/src/HGCalWaferMask.cc modified in PR(s): Add HCAL LLP Jet Skim config #41111

cmsbuild · 2023-03-24T08:34:53Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2023-03-24T08:35:10Z

please test

cmsbuild · 2023-03-24T14:54:09Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a565a/31578/summary.html
COMMIT: a607b84
CMSSW: CMSSW_13_1_X_2023-03-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41169/31578/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a565a/31578/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a565a/31578/git-merge-result

Comparison Summary

Summary:

You potentially removed 12 lines from the logs
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554286
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554252
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

civanch · 2023-03-24T17:42:59Z

+1

civanch · 2023-03-24T17:44:35Z

@AdrianoDee, @srimanob, please, sign this very technical fix.

AdrianoDee · 2023-03-24T17:47:33Z

+upgrade
(pretty technical)

cmsbuild · 2023-03-24T17:48:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-03-24T20:14:36Z

+1

iarspider added 2 commits March 24, 2023 09:06

Fix build failure in DBG_X

d9117e8

Update HGCalWaferMask.cc

52e08df

cmsbuild added this to the CMSSW_13_1_X milestone Mar 24, 2023

cmsbuild added geometry-pending pending-signatures orp-pending tests-started upgrade-pending code-checks-pending labels Mar 24, 2023

cmsbuild added the bug-fix label Mar 24, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 24, 2023

Code-format

a607b84

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-rejected labels Mar 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 24, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 24, 2023

cmsbuild mentioned this pull request Mar 24, 2023

Add upper cut on jet time to HLTJetTimingFilter #41089

Closed

cmsbuild added tests-approved and removed tests-started labels Mar 24, 2023

cmsbuild added geometry-approved and removed geometry-pending labels Mar 24, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 24, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 24, 2023

cmsbuild merged commit 73c4c34 into cms-sw:master Mar 24, 2023

iarspider deleted the patch-6 branch March 25, 2023 10:03

Fix build failure in DBG_X #41169

Fix build failure in DBG_X #41169

Uh oh!

Conversation

iarspider commented Mar 24, 2023

PR description:

PR validation:

Uh oh!

iarspider commented Mar 24, 2023

Uh oh!

iarspider commented Mar 24, 2023

Uh oh!

cmsbuild commented Mar 24, 2023

Uh oh!

smuzaffar commented Mar 24, 2023

Uh oh!

cmsbuild commented Mar 24, 2023

Uh oh!

cmsbuild commented Mar 24, 2023

Uh oh!

smuzaffar commented Mar 24, 2023

Uh oh!

cmsbuild commented Mar 24, 2023

Comparison Summary

Uh oh!

civanch commented Mar 24, 2023

Uh oh!

civanch commented Mar 24, 2023

Uh oh!

AdrianoDee commented Mar 24, 2023

Uh oh!

cmsbuild commented Mar 24, 2023

Uh oh!

rappoccio commented Mar 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants