Update to new ONNXRuntime api by iarspider · Pull Request #41118 · cms-sw/cmssw

iarspider · 2023-03-21T13:07:46Z

PR description:

Companion PR for cms-sw/cmsdist#8397

PR validation:

Bot tests

iarspider · 2023-03-21T13:08:20Z

please test with cms-sw/cmsdist#8397

cmsbuild · 2023-03-21T13:15:16Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41118/34755

ERROR: Build errors found during clang-tidy run.

PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:42:40: error: no member named 'GetInputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string input_name(session_->GetInputNameAllocated(i, allocator));
                                       ^
PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:60:41: error: no member named 'GetOutputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string output_name(session_->GetOutputNameAllocated(i, allocator));
                                        ^
Suppressed 356 warnings (355 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-03-21T14:59:16Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41118/34756

ERROR: Build errors found during clang-tidy run.

PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:42:40: error: no member named 'GetInputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string input_name(session_->GetInputNameAllocated(i, allocator).get());
                                       ^
PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:60:41: error: no member named 'GetOutputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string output_name(session_->GetOutputNameAllocated(i, allocator).get());
                                        ^
Suppressed 356 warnings (355 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-03-23T09:43:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41118/34802

ERROR: Build errors found during clang-tidy run.

PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:42:40: error: no member named 'GetInputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string input_name(session_->GetInputNameAllocated(i, allocator).get());
                                       ^
PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc:60:41: error: no member named 'GetOutputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
      std::string output_name(session_->GetOutputNameAllocated(i, allocator).get());
                                        ^
Suppressed 356 warnings (355 in non-user code, 1 with check filters).
--
DQM/EcalMonitorClient/src/MLClient.cc:167:37: error: no member named 'GetInputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
    const char* inputName = session.GetInputNameAllocated(0, allocator).get();
                                    ^
DQM/EcalMonitorClient/src/MLClient.cc:174:38: error: no member named 'GetOutputNameAllocated' in 'Ort::Session' [clang-diagnostic-error]
    const char* outputName = session.GetOutputNameAllocated(0, allocator).get();
                                     ^
Suppressed 1367 warnings (1366 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-04-03T09:04:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41118/34997

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DQM/EcalMonitorClient/src/MLClient.cc modified in PR(s): Adding the Ecal Endcaps to the ML based online ECAL DQM #41175
- File PhysicsTools/ONNXRuntime/src/ONNXRuntime.cc modified in PR(s): Extend onnxruntime gpu interface to producers using onnxruntime #39402

cmsbuild · 2023-04-03T09:04:52Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

DQM/EcalMonitorClient (dqm)
PhysicsTools/ONNXRuntime (reconstruction)

@micsucmed, @emanueleusai, @clacaputo, @cmsbuild, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @AnnikaStein, @riga, @argiro, @thomreis, @wang0jin this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2023-04-05T07:09:16Z

test parameters:

pull_request = Update onnxruntime to 1.14.1 cmsdist#8397

smuzaffar · 2023-04-05T07:10:44Z

please test

cmsbuild · 2023-04-06T00:19:17Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f04c2/31828/summary.html
COMMIT: 8f038cc
CMSSW: CMSSW_13_1_X_2023-04-04-2300/el8_amd64_gcc11
Additional Tests: THREADING,PROFILING,GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41118/31828/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f04c2/31828/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f04c2/31828/git-merge-result

Comparison Summary

Summary:

You potentially added 8 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 47
DQMHistoTests: Total histograms compared: 3365163
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3365135
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
Checked 202 log files, 155 edm output root files, 47 DQM output files
TriggerResults: no differences found

GPU Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19862
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19853
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: no differences found

mandrenguyen · 2023-04-07T05:27:49Z

+reconstruction

smuzaffar · 2023-04-07T15:28:10Z

@cms-sw/dqm-l2 can you please review this? This change is needed for onnxruntime 1.14.1

@cms-sw/orp-l2 , this should be merged along with cms-sw/cmsdist#8397

emanueleusai · 2023-04-10T07:58:57Z

+1

cmsbuild · 2023-04-10T07:59:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-04-10T19:55:14Z

+1

iarspider added 2 commits March 21, 2023 14:01

Update to new ONNXRuntime api

70c5121

Fix

a135188

cmsbuild added this to the CMSSW_13_1_X milestone Mar 21, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 21, 2023

cmsbuild added tests-started requires-external and removed tests-pending labels Mar 21, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 21, 2023

iarspider mentioned this pull request Mar 21, 2023

Update onnxruntime to 1.14.1 cms-sw/cmsdist#8397

Merged

Update ONNXRuntime.cc

cac6559

cmsbuild added tests-pending code-checks-pending and removed tests-started requires-external code-checks-rejected labels Mar 21, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 21, 2023

One more fix

e4a7fdf

cmsbuild added dqm-pending code-checks-pending and removed code-checks-rejected labels Mar 23, 2023

cmsbuild added the code-checks-pending label Apr 3, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 3, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2023

cmsbuild added tests-approved and removed tests-started labels Apr 6, 2023

smuzaffar mentioned this pull request Apr 6, 2023

[GCC12] Apply patch for spurious Warray-bounds diagnostics cms-sw/cmsdist#8431

Merged

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 7, 2023

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 10, 2023

cmsbuild added orp-approved and removed orp-pending labels Apr 10, 2023

cmsbuild merged commit 2fac98b into cms-sw:master Apr 10, 2023

cmsbuild mentioned this pull request Apr 11, 2023

Update Tensorflow to version 2.11.0 cms-sw/cmsdist#8258

Closed

abhih1 mentioned this pull request Apr 27, 2023

Adding the Ecal Endcaps to the ML based online ECAL DQM [13_0_X] #41195

Merged

iarspider deleted the onnxruntime-new-api branch February 27, 2024 10:16

Conversation

iarspider commented Mar 21, 2023

PR description:

PR validation:

Uh oh!

iarspider commented Mar 21, 2023

Uh oh!

cmsbuild commented Mar 21, 2023

Uh oh!

cmsbuild commented Mar 21, 2023

Uh oh!

cmsbuild commented Mar 23, 2023

Uh oh!

cmsbuild commented Apr 3, 2023

Uh oh!

cmsbuild commented Apr 3, 2023

Uh oh!

smuzaffar commented Apr 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Apr 5, 2023

Uh oh!

cmsbuild commented Apr 6, 2023

Comparison Summary

GPU Comparison Summary

Uh oh!

mandrenguyen commented Apr 7, 2023

Uh oh!

smuzaffar commented Apr 7, 2023

Uh oh!

emanueleusai commented Apr 10, 2023

Uh oh!

cmsbuild commented Apr 10, 2023

Uh oh!

rappoccio commented Apr 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

smuzaffar commented Apr 5, 2023 •

edited

Loading