-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Move dictionary declarations of Alpaka serial backend data products to the host classes_def.xml #40792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Move dictionary declarations of Alpaka serial backend data products to the host classes_def.xml #40792
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
DataFormats/PortableTestObjects/src/alpaka/classes_serial_def.xml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,4 @@ | ||
| #include "DataFormats/Common/interface/Wrapper.h" | ||
| #include "DataFormats/Portable/interface/Product.h" | ||
| #include "DataFormats/PortableTestObjects/interface/TestHostCollection.h" | ||
| #include "DataFormats/PortableTestObjects/interface/TestSoA.h" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,18 @@ | ||
| <lcgdict> | ||
| <class name="portabletest::TestSoA"/> | ||
| <class name="portabletest::TestSoA::View"/> | ||
|
|
||
| <class name="portabletest::TestHostCollection"/> | ||
| <read | ||
| sourceClass="portabletest::TestHostCollection" | ||
| targetClass="portabletest::TestHostCollection" | ||
| version="[1-]" | ||
| source="portabletest::TestSoA layout_;" | ||
| target="buffer_,layout_,view_" | ||
| embed="false"> | ||
| <![CDATA[ | ||
| portabletest::TestHostCollection::ROOTReadStreamer(newObj, onfile.layout_); | ||
| ]]> | ||
| </read> | ||
| <class name="edm::Wrapper<portabletest::TestHostCollection>" splitLevel="0"/> | ||
| </lcgdict> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this approach of having the "serial" data formats in the main (non-alpaka) directory becomes the preferred one, we should find a way to automate this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise when we add a new backend, we need to go through all DataFormats and add it there, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see @smuzaffar opened an issue cms-sw/cmssw-config#93 to improve the syntax, so how about we proceed now with this approach and invert it later on? (I'd expect the improvement to be available before we would be adding a new backend)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next "backend" we could add (even if more for testing purpose than for use in production) would probably be the CPU block-parallel one based on TBB.
If we add that,
<flags ALPAKA_BACKENDS="cuda rocm"/>would still be the correct choice for anyDataFormats.So, yes, I agree we can move ahead with this approach, and improve things later.