Skip to content

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 3, 2023

PR description:

Title says it all, follows up to #40661 (comment)

PR validation:

Run runTheMatrix.py -l 1005.0 -t 4 -j 8 successfully and checked that there are no residual warning

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Feb 3, 2023

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40686/34042

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • DQMOffline/Alignment (dqm)

@perrotta, @rappoccio, @pmandrik, @emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @davidlange6, @micsucmed, @fabiocos, @rvenditti can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 3, 2023

test parameters:

  • workflow = 1005.0

@mmusich
Copy link
Contributor Author

mmusich commented Feb 3, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65bb4c/30386/summary.html
COMMIT: 2d32d25
CMSSW: CMSSW_13_0_X_2023-02-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40686/30386/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65bb4c/30386/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65bb4c/30386/git-merge-result

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 20 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555473
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 4, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65bb4c/30396/summary.html
COMMIT: 2d32d25
CMSSW: CMSSW_13_0_X_2023-02-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40686/30396/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 27 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3570257
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3570229
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 217 log files, 165 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Feb 4, 2023

As expected the error message present in IBs is now gone (see log)

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a31eb30 into cms-sw:master Feb 6, 2023
@mmusich mmusich deleted the fix_TkAlCosmicsDuringCollisions0T branch February 6, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants