Skip to content

Conversation

@vlimant
Copy link
Contributor

@vlimant vlimant commented Feb 3, 2023

PR description:

there should be no need for a specific configuration for data or MC for NANO. This removes the call for two different customize function (hopefully we can come up with an update to remove the need for that customize all together)

PR validation:

the nano matrix ran through.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40682/34034

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

A new Pull Request was created by @vlimant (vlimant) for master.

It involves the following packages:

  • Configuration/Applications (operations)
  • PhysicsTools/NanoAOD (xpog)

@perrotta, @rappoccio, @swertz, @vlimant, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @gpetruc, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor Author

vlimant commented Feb 3, 2023

enable nano

@vlimant
Copy link
Contributor Author

vlimant commented Feb 3, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff771b/30380/summary.html
COMMIT: 75e4e54
CMSSW: CMSSW_13_0_X_2023-02-02-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40682/30380/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555470
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 11
  • DQMHistoTests: Total histograms compared: 10829
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 10829
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
  • Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.232 2.232 0.000 ( +0.0% ) 9.54 9.24 +3.3% 1.412 1.481
2500.311 2.323 2.323 0.000 ( +0.0% ) 9.23 9.14 +1.0% 1.753 1.736
2500.312 2.277 2.277 0.000 ( +0.0% ) 9.38 9.22 +1.7% 1.731 1.727
2500.33 1.098 1.098 0.000 ( +0.0% ) 22.23 20.95 +6.1% 1.630 1.587
2500.331 1.393 1.393 0.000 ( +0.0% ) 16.26 15.81 +2.8% 1.792 1.611
2500.332 1.324 1.324 0.000 ( +0.0% ) 18.13 17.86 +1.5% 1.834 1.534
2500.401 2.138 2.138 0.000 ( +0.0% ) 10.40 10.50 -0.9% 1.106 1.171
2500.501 1.711 1.711 0.000 ( +0.0% ) 16.76 16.58 +1.1% 1.063 1.134
2500.511 1.123 1.123 0.000 ( +0.0% ) 31.06 30.86 +0.6% 1.291 1.354
2500.601 2.050 2.050 0.000 ( +0.0% ) 12.57 12.31 +2.1% 1.135 1.113

@vlimant
Copy link
Contributor Author

vlimant commented Feb 6, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 6, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants