Add a test for ROCm libraries and build rules by fwyzard · Pull Request #40637 · cms-sw/cmssw

fwyzard · 2023-01-29T22:27:15Z

PR description:

This PR adds new packages to test the implementation and usage of ROCm libraries for device code in CMSSW plugins and executables.

The package HeterogeneousTest/ROCmDevice implements a library that defines and exports ROCm device-only functions, and a plugin and test that use them.

The package HeterogeneousTest/ROCmKernel implements a library that imports device functions from HeterogeneousTest/ROCmDevice to define and export ROCm kernels, and a plugin and test that use them.

The package HeterogeneousTest/ROCmWrapper implements a library that imports kernels from HeterogeneousCTest/ROCmKernel to define and export host-only wrappers around them, usable by non-ROCm libraries, plugins and applications, and implements a plugin and test that use them.

The package HeterogeneousTest/ROCmOpaque implements a library that use the wrappers from HeterogeneousTest/ROCmWrapper to define and export host-only functions around the whole ROCm section, usable by libraries, plugins and applications that are not ROCm-aware, and implements a plugin and test that use them.

The PR builds on top of and includes:

PR validation:

The new unit tests compile and pass.

cmsbuild · 2023-01-29T22:32:01Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40637/33932

ERROR: Build errors found during clang-tidy run.

HeterogeneousCore/ROCmTestHidden/src/DeviceAdditionHidden.cc:7:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 98 warnings (97 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmTestKernel/plugins/ROCmTestKernelAdditionModule.cc:17:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
HeterogeneousCore/ROCmTestDevice/plugins/ROCmTestDeviceAdditionModule.cc:17:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmTestWrapper/plugins/ROCmTestWrapperAdditionModule.cc:18:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-01-30T16:51:34Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40637/33941

ERROR: Build errors found during clang-tidy run.

HeterogeneousTest/ROCmOpaque/src/DeviceAdditionOpaque.cc:7:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 98 warnings (97 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmWrapper/plugins/ROCmTestWrapperAdditionModule.cc:20:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmKernel/plugins/ROCmTestKernelAdditionModule.cc:19:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmDevice/plugins/ROCmTestDeviceAdditionModule.cc:19:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2023-01-31T10:47:21Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40637/33954

ERROR: Build errors found during clang-tidy run.

Suppressed 98 warnings (97 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmOpaque/plugins/ROCmTestOpaqueAdditionModule.cc:14:10: error: 'HeterogeneousCore/ROCmServices/interface/ROCmService.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmServices/interface/ROCmService.h"
         ^
Suppressed 874 warnings (873 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmKernel/plugins/ROCmTestKernelAdditionModule.cc:16:10: error: 'HeterogeneousCore/ROCmServices/interface/ROCmService.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmServices/interface/ROCmService.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmDevice/plugins/ROCmTestDeviceAdditionModule.cc:16:10: error: 'HeterogeneousCore/ROCmServices/interface/ROCmService.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmServices/interface/ROCmService.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
HeterogeneousTest/ROCmWrapper/plugins/ROCmTestWrapperAdditionModule.cc:16:10: error: 'HeterogeneousCore/ROCmServices/interface/ROCmService.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmServices/interface/ROCmService.h"
         ^
Suppressed 909 warnings (908 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2023-01-31T10:49:32Z

HeterogeneousTest/ROCmOpaque/test/testROCmTestAdditionModules.py

+)
+
+process.path = cms.Path(
+     process.rocmTestDeviceAdditionModule +


@makortel note that this one works with ROCm, while it does not work with CUDA.

fwyzard · 2023-02-01T11:37:33Z

please test

fwyzard · 2023-02-01T11:38:35Z

+heterogeneous

fwyzard · 2023-02-01T11:38:42Z

unhold

cmsbuild · 2023-02-01T11:49:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40637/33992

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/ROCmServices/BuildFile.xml modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/interface/ROCmService.h modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/plugins/BuildFile.xml modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/plugins/plugins.cc modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/src/ROCmService.cc modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/test/BuildFile.xml modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/test/testROCmService.cpp modified in PR(s): Implement a first draft of the ROCmServices #40642
- File HeterogeneousCore/ROCmServices/test/testROCmService.py modified in PR(s): Implement a first draft of the ROCmServices #40642

cmsbuild · 2023-02-01T11:49:48Z

Pull request #40637 was updated. can you please check and sign again.

cmsbuild · 2023-02-01T16:17:35Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7e4082/30327/summary.html
COMMIT: 879f836
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40637/30327/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555470
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2023-02-01T17:44:49Z

+1

Updates in HeterogeneousCore/ROCmServices were already merged with Implement a first draft of the ROCmServices #40642
Updates in HeterogeneousTest are specific of this PR

perrotta · 2023-02-01T17:45:47Z

merge

cmsbuild added this to the CMSSW_13_0_X milestone Jan 29, 2023

cmsbuild added code-checks-pending new-package-pending orp-pending pending-signatures tests-pending labels Jan 29, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 29, 2023

smuzaffar mentioned this pull request Jan 30, 2023

[BuildRules] Use hipcc to link product which has hip.cc sources cms-sw/cmsdist#8274

Merged

fwyzard force-pushed the ROCmTestDeviceLib branch from 5005752 to 90dcb0d Compare January 30, 2023 16:46

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 30, 2023

fwyzard force-pushed the ROCmTestDeviceLib branch from 90dcb0d to 9bf3433 Compare January 30, 2023 16:47

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 30, 2023

fwyzard mentioned this pull request Jan 30, 2023

Implement HIP/ROCm build rules and test packages #40627

Closed

fwyzard force-pushed the ROCmTestDeviceLib branch from 9bf3433 to a6f10dc Compare January 31, 2023 10:39

cmsbuild added code-checks-pending heterogeneous-pending and removed new-package-pending code-checks-rejected labels Jan 31, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 31, 2023

fwyzard commented Jan 31, 2023

View reviewed changes

fwyzard force-pushed the ROCmTestDeviceLib branch from a6f10dc to 85e936f Compare January 31, 2023 12:45

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 31, 2023

fwyzard force-pushed the ROCmTestDeviceLib branch from b242e04 to 879f836 Compare February 1, 2023 11:37

cmsbuild added tests-started code-checks-pending and removed tests-rejected requires-external code-checks-approved labels Feb 1, 2023

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures hold heterogeneous-pending labels Feb 1, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 1, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 1, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 1, 2023

cmsbuild merged commit e10bed9 into cms-sw:master Feb 1, 2023

This was referenced Feb 2, 2023

Custom Run 3 PFScouting NanoAOD #40438

Merged

[Tensorflow] Build with GPU enabled cms-sw/cmsdist#7648

Merged

fwyzard deleted the ROCmTestDeviceLib branch February 2, 2023 12:45

cmsbuild mentioned this pull request Feb 2, 2023

Update Tensorflow to version 2.11.0 cms-sw/cmsdist#8258

Closed

Conversation

fwyzard commented Jan 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Jan 29, 2023

Uh oh!

cmsbuild commented Jan 30, 2023

Uh oh!

cmsbuild commented Jan 31, 2023

Uh oh!

fwyzard Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

makortel Jan 31, 2023

Choose a reason for hiding this comment

Uh oh!

fwyzard commented Feb 1, 2023

Uh oh!

fwyzard commented Feb 1, 2023

Uh oh!

fwyzard commented Feb 1, 2023

Uh oh!

cmsbuild commented Feb 1, 2023

Uh oh!

cmsbuild commented Feb 1, 2023

Uh oh!

cmsbuild commented Feb 1, 2023

RelVals-INPUT

Comparison Summary

Uh oh!

perrotta commented Feb 1, 2023

Uh oh!

perrotta commented Feb 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fwyzard commented Jan 29, 2023 •

edited

Loading