-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Fix for wf 11634.15
#40539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix for wf 11634.15
#40539
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e2530f1
modify Run3 PSets for SoftLeptonByMVAComputers instead of individual …
francescobrivio cc2047c
remove nanoAOD deprecated Run3 jet flavour taggers
francescobrivio 3542236
remove btagCSVV2 plot from nanoDQM for Run3
francescobrivio 3a70499
add btagCSVV2 to run2_nanoAOD_ANY in AddBTaggingScores method
francescobrivio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these be put back in for
run2_nanoAOD_ANYas well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check a run2 wf and add it back in case.
Should I add the modifier inside this function?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the
BTAGVARSPSet can be modified directly (e.g. in L175)?Edit: sorry, spoke too fast, that isn't sufficient. Yes, I suppose it has to go in this function, as well as below as well (L686 and 859)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swertz I'm looking into this, but aren't these already added back in:
?
Those contain exactly:
So
jetTable,jetPuppiTableandfatJetTablewill contain the correctbtagCSVV2forrun2_nanoAOD_ANY.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, but in some cases a new table is created instead of reusing the default NanoAOD ones, e.g. in
cmssw/PhysicsTools/NanoAOD/python/custom_jme_cff.py
Line 498 in 3542236
Haven't checked when that is done in practice, perhaps @nurfikri89 can chime in...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok got it, thanks!
Indeed I was testing a few workflows from the matrix that run the
custom_jme_cff(both for Run2 and Run3) and none of them invokes this method to add the btagging info to the table! 😄But I agree it should be there just in case: so I will add this customization in the function!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addessed in 3a70499
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added in the tests also the
2500.31wf which actually runs therun2_nanoAOD_106Xv2era.