Skip to content

Conversation

@saumyaphor4252
Copy link
Contributor

PR description:

This PR is a forward port of #40473 with the addition of updated 2017 realistic GT.
It updates the following MC GTs:

  • realistic Heavy Ion MC GTs (auto:phase1_2022_realistic_hi, auto:phase1_2023_realistic_hi) with latest SiPixel bad component tags requested in this CMSTalk post [1]. More details for the request can be found in [2].
  • realistic 2017 GT (auto:phase1_2017_realistic) with correct UL 2017 JER tags requested in this CMSTalk post [3].

[1] https://cms-talk.web.cern.ch/t/125x-run-3-hi-gt-update-for-pixel-bad-components/19077
[2] https://cms-talk.web.cern.ch/t/request-alca-input-to-update-vertex-in-mc-of-2022-pbpb-test-run/18799/10
[3] https://cms-talk.web.cern.ch/t/gt-update-wrong-ul-2017-jr-tags/19081

GT Differeces

PR validation:

Successfully ran:
runTheMatrix.py -l 159.0,10024.0 -j10 --ibeos
which consumes the auto:phase1_2017_realistic and auto:phase1_2022_realistic_hi conditions.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Forward port of #40473. No other backport expected.

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40482/33660

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

@saumyaphor4252 please update the PR title to reflect that it's the 2017 UL realistic GT and the 2022/2023 HI MC GT

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b6a15/29915/summary.html
COMMIT: 1334d84
CMSSW: CMSSW_13_0_X_2023-01-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40482/29915/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b6a15/29915/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6b6a15/29915/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.01 step 3
140.03 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3061 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 67
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555449
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

+alca

  • diffs in HI wf and 2017 MC workflow as expected
  • PR title should be edited

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@saumyaphor4252 saumyaphor4252 changed the title Update Heavy Ion and realistic MC GTs Update 2017 UL realistic GT and 2022/2023 HI MC GTs Jan 12, 2023
@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants