Skip to content

Disable computation of Q probability in SiPixel template CPE for iterative tracking #39776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 5 commits into from
Oct 28, 2022
Merged

Disable computation of Q probability in SiPixel template CPE for iterative tracking #39776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6282af
Use SiPixel CPE (cluster repair) with speed=0; i.e., without ProbQ co…
mmasciov Oct 17, 2022
5aa1f4a
Remove warning when disabling probQ computation
mmasciov Oct 17, 2022
2bde976
update WithoutProbQ for phase2
slava77 Oct 19, 2022
8b4f5df
Restore previous warning, except for default value
mmasciov Oct 22, 2022
bd6dab7
Use float representation in comparison
mmasciov Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DataFormats/TrackerRecHit2D/interface/SiPixelRecHitQuality.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ class SiPixelRecHitQuality {
inline void setProbabilityQ(float prob, QualWordType& qualWord) const {
if (prob > 1.0f && prob <= 1.0f + std::numeric_limits<float>::epsilon()) {
prob = 1;
} else if (prob == -1.0f) {
// default prob in absence of Q probability computation is -1 --> set to 0
prob = 0;
} else if (prob < 0.0f || prob > 1.0f + std::numeric_limits<float>::epsilon()) {
warningOutOfBoundProb("Q", prob, qualWord);
prob = 0;
Expand Down
5 changes: 4 additions & 1 deletion RecoLocalTracker/SiPixelRecHits/python/PixelCPEClusterRepair_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@

from RecoLocalTracker.SiPixelRecHits._templates2_default_cfi import _templates2_default
templates2 = _templates2_default.clone()

templates2_speed0 = _templates2_default.clone(
ComponentName = "PixelCPEClusterRepairWithoutProbQ",
speed = 0
)
1 change: 1 addition & 0 deletions RecoTracker/TrackProducer/python/TrackProducerIterativeDefault_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
useSimpleMF = cms.bool(True),
SimpleMagneticField = cms.string("ParabolicMf"),
Propagator = cms.string('PropagatorWithMaterialParabolicMf'),
TTRHBuilder = cms.string('WithAngleAndTemplateWithoutProbQ')
)
5 changes: 4 additions & 1 deletion RecoTracker/TransientTrackingRecHit/python/TTRHBuilderWithTemplate_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@
from Configuration.Eras.Modifier_phase1Pixel_cff import phase1Pixel
phase1Pixel.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = 'PixelCPEClusterRepair')

TTRHBuilderAngleAndTemplateWithoutProbQ = TTRHBuilderAngleAndTemplate.clone(ComponentName = 'WithAngleAndTemplateWithoutProbQ')
phase1Pixel.toModify(TTRHBuilderAngleAndTemplateWithoutProbQ, PixelCPE = 'PixelCPEClusterRepairWithoutProbQ')

# Turn off template reco for phase 2 (when not supported)
from Configuration.ProcessModifiers.PixelCPEGeneric_cff import PixelCPEGeneric
PixelCPEGeneric.toModify(TTRHBuilderAngleAndTemplate, PixelCPE = 'PixelCPEGeneric')

PixelCPEGeneric.toModify(TTRHBuilderAngleAndTemplateWithoutProbQ, PixelCPE = 'PixelCPEGeneric')