[12_4_X] Update Run3 MC GTs + swap update Vertex smearing + update offline Run3 GTs#39019
Conversation
|
A new Pull Request was created by @francescobrivio for CMSSW_12_4_X. It involves the following packages:
@malbouis, @civanch, @yuanchao, @jordan-martins, @bsunanda, @makortel, @bbilin, @saumyaphor4252, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @clacaputo, @kskovpen, @jpata, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Who'll be the primary user of this? |
HLT studies |
|
Sorry, but I suppose this is for the 12_4 MC production, no? |
Yes, this is used in the 12_4_X MC production. On the top of this change, we'll prove you @Martin-Grunewald et al special GTs that are including the JEC + PF for your autoCondHLT |
|
@cmsbuild , please test |
|
@cmsbuild , please abort
|
Why does it need to be in release? Production does not care |
|
hold
|
|
Pull request has been put on hold by @mmusich |
|
Marco, this was agreed by PPD L1s, and ORP yesterday. Sal, Jordan, Kaori should comment... |
|
Please let's have a written justification. IIUC there are no minutes of the ORP meeting |
|
As far as I kow the ORP meeting yesterday had been cancelled:
|
use for what reason? Why are we changing the physics output of a closed release? |
For reco, @clacaputo was looking at this one. |
|
+reconstruction |
|
+geometry |
|
@bsunanda maybe you could also sign for simulation? |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
hi @cms-sw/orp-l2
in the last few IBs we had inconsistencies so it would be nice to merge this as soon as possible, thanks! |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd62c0/29433/summary.html Comparison SummarySummary:
|
|
+1 |
| step1Up2018HiProdDefaults = merge ([{'--eventcontent':'RAWSIM'},step1Up2018HiDefaults]) | ||
| # step1 gensim: for 2021 HI prod | ||
| step1Up2021HiProdDefaults = merge ([{'--conditions':'auto:phase1_2022_realistic_hi','--era':'Run3_pp_on_PbPb','--beamspot':'Run3RoundOptics25ns13TeVLowSigmaZ','--eventcontent':'RAWSIM','--geometry':'DB:Extended'},step1Up2018HiDefaults]) | ||
| step1Up2021HiProdDefaults = merge ([{'--conditions':'auto:phase1_2022_realistic_hi','--era':'Run3_pp_on_PbPb','--beamspot':'Realistic25ns13p6TeVEarly2022Collision','--eventcontent':'RAWSIM','--geometry':'DB:Extended'},step1Up2018HiDefaults]) |
There was a problem hiding this comment.
@cms-sw/alca-l2
I'm having trouble understanding why this change is needed (and two other ones below).
After this PR, the MC GTs for 2022_hi, 2023, and 2024 [1] still use the 'old' beamspot tags, i.e. Run3RoundOptics25ns13TeVLowSigmaZ (iiuc, this is because the PU samples of the corresponding RelVals were produced with the 'old' beamspot). At the same time, this PR changes the beamspot parameters used in the GEN-SIM step of those workflows to the 'new' one, i.e. Realistic25ns13p6TeVEarly2022Collision.
Taking wf 12434.0 as an example (pp 2023, no PU), step-1 is now as in [2], and this plot from the PR tests looks odd.
Am I missing something?
[1]
phase1_2022_realistic_hi: https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/124X_mcRun3_2022_realistic_HI_v12phase1_2023_realistic: https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/124X_mcRun3_2023_realistic_v13phase1_2024_realistic: https://cms-conddb.cern.ch/cmsDbBrowser/list/Prod/gts/124X_mcRun3_2024_realistic_v13
[2]
cmsDriver.py TTbar_14TeV_TuneCP5_cfi -s GEN,SIM -n 10 \
--conditions auto:phase1_2023_realistic --beamspot Realistic25ns13p6TeVEarly2022Collision \
--datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3 --relval 9000,100
There was a problem hiding this comment.
This looks like a mistake.
In the master version of this PR: #38760 the >= 2022 scenarios got updated because the corresponding PR updating the PU libraries has changed the later Run-3 years as well (see #39041) but in this case this is not appropriate.
I suggest this bug-fix PR #40238 to resolve the issue.
Alternatively we'd need updates to GlobalTags as well as PU libraries.
| 'HLTmenu': '@relval2022', | ||
| 'Era' : 'Run3', | ||
| 'BeamSpot': 'Run3RoundOptics25ns13TeVLowSigmaZ', | ||
| 'BeamSpot': 'Realistic25ns13p6TeVEarly2022Collision', |
| 'HLTmenu': '@relval2022', | ||
| 'Era' : 'Run3', | ||
| 'BeamSpot': 'Run3RoundOptics25ns13TeVLowSigmaZ', | ||
| 'BeamSpot': 'Realistic25ns13p6TeVEarly2022Collision', |
17 participants
PR description:
Backport of:
Run3RoundOptics25ns13TeVLowSigmaZwithRealistic25ns13p6TeVEarly2022Collisionvtx smearing #38760 - update BeamSpot and VtxSmearing to Run3 valuesphase1_2022_realistic_postEEkey inautoCondfor the postEE (Run3Summer22EE) MC campaignThis PR is meant to generally update the GTs in 12_4_X to make them even with respect to 12_5_X and 12_6_X.
The PR includes the swap of
Run3RoundOptics25ns13TeVLowSigmaZwithRealistic25ns13p6TeVEarly2022Collisionsmearing so that the tests also use the correct new vertex smearing (GS file added in #39548)New tags included:
auto:phase1_2022_realistic:BeamSpotObjects_Realistic25ns_13p6TeVCollisions_Early2022_v3_mcBeamSpotOnlineObjects_Realistic25ns_13p6TeVCollisions_Early2022_v2_mcSiStripBadComponents_realisticMC_for2022_v2_mcSiPixelQuality_phase1_2022_v2_mcSiPixelQuality_forDigitizer_phase1_2022_v2_mcwith label forDigitizer`SiPixelQuality_phase1_2022_forRawToDigi_v0 withlabel forRawToDigi`auto:phase1_2022_cosmics:BeamSpotObjects_Realistic25ns_13p6TeVCollisions_Early2022_v3_mcBeamSpotOnlineObjects_Realistic25ns_13p6TeVCollisions_Early2022_v2_mcSiStripBadComponents_realisticMC_for2022_v2_mcSiPixelQuality_phase1_2022_v2_mcSiPixelQuality_forDigitizer_phase1_2022_v2_mcwith labelforDigitizerauto:phase1_2022_realistic_hi:SiStripBadComponents_realisticMC_for2022_v2_mcSiPixelQuality_phase1_2022_v2_mcSiPixelQuality_forDigitizer_phase1_2022_v2_mcwith labelforDigitizerauto:phase1_2023_realistic:SiStripBadComponents_realisticMC_for2022_v2_mcSiPixelQuality_phase1_2023_v2_mcSiPixelQuality_forDigitizer_phase1_2023_v2_mcwith labelforDigitizerauto:phase1_2024_realistic:SiStripBadComponents_realisticMC_for2022_v2_mcSiPixelQuality_phase1_2024_v2_mcSiPixelQuality_forDigitizer_phase1_2024_v2_mcwith labelforDigitizerauto:run3_dataauto:run3_data_relval:auto:run3_datawith fixed L1 menuGT Diffs:
PR validation:
Code compiles - ran the tests in the master PR
Backport:
Backport of #38760, #39645 and #39823