Skip to content

Conversation

@slava77
Copy link
Contributor

@slava77 slava77 commented Aug 4, 2022

Discussion in PPD Aug 4
https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to
appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit.

This PR makes the switch and removes Run3_ckfPixelLessStep, which is now identical to Run3
(I checked this using the run3 wf 11834.0 expanded config for step3).

@cms-sw/tracking-pog-l2

@slava77
Copy link
Contributor Author

slava77 commented Aug 4, 2022

backport of #38967

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2022

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @lecriste, @trtomei, @mmusich, @mtosi, @beaucero, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Aug 15, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b6218/26819/summary.html
COMMIT: 343e457
CMSSW: CMSSW_12_4_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38968/26819/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 23087 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 21240
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3655978
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.008 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 138.5 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 3 / 49 workflows

@mmusich
Copy link
Contributor

mmusich commented Aug 17, 2022

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you have a look to this?

@cms-sw/orp-l2 the creation of a release with this PR needs to be timed in carefully because it has implications on the structure of the output datasets for prompt reco (era or processing version change). This ping is just to collect signatures in case of need.

@AdrianoDee
Copy link
Contributor

+upgrade

@bbilin
Copy link
Contributor

bbilin commented Aug 17, 2022

+pdmv

@perrotta
Copy link
Contributor

Given the discussion in the Mattermost ORM channel I wonder whether we should also merge this PR, and cut a 12_4_7 right after with all tracking changes included all at once...

@mmusich
Copy link
Contributor

mmusich commented Aug 18, 2022

hi @perrotta @qliphy

Given the discussion in the Mattermost ORM channel I wonder whether we should also merge this PR, and cut a 12_4_7 right after with all tracking changes included all at once...

given the blessing of O&C and the agreement of the ORM, we think we can go ahead with the merge of this PR and the creation of CMSSW_12_4_7.
Thank you.

@perrotta
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@slava77
Copy link
Contributor Author

slava77 commented Nov 30, 2023

type tracking

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b6218/36217/summary.html
COMMIT: 343e457
CMSSW: CMSSW_12_4_X_2023-11-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38968/36217/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 18 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3766083
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3766053
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants