-
Notifications
You must be signed in to change notification settings - Fork 4.6k
switch pixelLess iteration to use CKF instead of mkFit #38968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch pixelLess iteration to use CKF instead of mkFit #38968
Conversation
|
backport of #38967 |
|
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_12_4_X. It involves the following packages:
@perrotta, @rappoccio, @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b6218/26819/summary.html Comparison SummarySummary:
|
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you have a look to this? @cms-sw/orp-l2 the creation of a release with this PR needs to be timed in carefully because it has implications on the structure of the output datasets for prompt reco (era or processing version change). This ping is just to collect signatures in case of need. |
|
+upgrade
|
|
+pdmv |
|
Given the discussion in the Mattermost ORM channel I wonder whether we should also merge this PR, and cut a 12_4_7 right after with all tracking changes included all at once... |
given the blessing of O&C and the agreement of the ORM, we think we can go ahead with the merge of this PR and the creation of CMSSW_12_4_7. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged. |
|
type tracking |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2b6218/36217/summary.html Comparison SummarySummary:
|
Discussion in PPD Aug 4
https://indico.cern.ch/event/1187803/#43-discussion-of-reversion-to
appears to be converging to the decision to switch the pixelLess iteration to use CKF instead of mkFit.
This PR makes the switch and removes Run3_ckfPixelLessStep, which is now identical to Run3
(I checked this using the run3 wf 11834.0 expanded config for step3).
@cms-sw/tracking-pog-l2