Updated way to store DeepTau WPs in nanoAOD

[kandrosov]

PR description:

Splitting DM storage format related modifications into a separate PR. See #38726 and #38751 for details.

Following modifications are introduced:

• Unify WP masking interface to a single function _tauIdWPMask();
• Option to compute WP flags from raw scores (from_raw argument in _tauIdWPMask()) given the threshold values, instead of reading them directly from MINIAOD;
• Change the format of storing WPs from bitmask to integer values for user-friendliness.

Change of the format of storing WPs affects all present tauIDs and thus is not backward compatible. For instance if old versions of nano (with old eras) were produced with this PR integrated they would have format which is not backward compatible with the same versions without this PR. We think, however, that there is not realistic use-case, i.e. old versions of nano are not produced with new releases. Keeping backward compatibility is possible, but implementation will be painful. Comments from experts are welcome.

Backport to 12_4_X foreseen.

PR validation:

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38776/31114

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/boostedTaus_cff.py modified in PR(s): DeepTau v2p5 in nanoAOD #38726
  • File PhysicsTools/NanoAOD/python/nanoDQM_cff.py modified in PR(s): DeepTau v2p5 in nanoAOD #38726
  • File PhysicsTools/NanoAOD/python/nanoDQM_cfi.py modified in PR(s): Adding HZZ electron MVA ID #38355, DeepTau v2p5 in nanoAOD #38726
  • File PhysicsTools/NanoAOD/python/taus_cff.py modified in PR(s): DeepTau v2p5 in nanoAOD #38726
  • File RecoTauTag/RecoTau/python/tauIdWPsDefs.py modified in PR(s): DeepTau v2p5 in nanoAOD #38726
  • File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): DeepTau v2p5 in nanoAOD #38726

[cmsbuild]

A new Pull Request was created by @kandrosov (Konstantin Androsov) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)
• RecoTauTag/RecoTau (reconstruction)

@gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks.
@mbluj, @gpetruc, @azotz, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c956ff/26309/summary.html
COMMIT: 19182bb
CMSSW: CMSSW_12_5_X_2022-07-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38776/26309/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 21 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 76
• DQMHistoTests: Total successes: 3662306
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -41.202 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -4.781 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 1325.81 ): -9.180 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 136.8523 ): -3.332 KiB Physics/NanoAODDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

I confirm this only update the bitmask/int

tau:

boostedTau:

[mariadalfonso]

@kandrosov we can close this PR, as is clear what the int vs bit mask does.

(we cannot merge like this because the history will add the new ID, then remove them re-add again)