Add Run3 wfs (NanoV10) #38733

kskovpen · 2022-07-14T07:18:29Z

PR description:

Addition of the new Run3 NanoV10 wfs for data (140.001, 140.002) and MC (offset .602). Also addresses https://its.cern.ch/jira/projects/PDMVRELVALS/issues/PDMVRELVALS-155 (for data). Comments are welcome.

@bbilin @jmartinb @rappoccio @kmaeshima @cms-sw/xpog-l2 @mmusich

PR validation:

Tested on the aforementioned wfs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport

cmsbuild · 2022-07-14T07:25:27Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38733/31037

This PR adds an extra 68KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add Run3 ALCA Express/Prompt workflow #38681, Reorganize FastSim Run3 workflow #38660
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Clean up Phase-2 geometry (Up to D85) #38702, Reorganize FastSim Run3 workflow #38660, Add run3 tracking low pu era #33532

cmsbuild · 2022-07-14T07:25:50Z

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

kskovpen · 2022-07-14T07:34:31Z

test parameters:

workflow = 11634.602
pull_request = trivial V10 customize (12_4) #38667
relvals_opt = -w upgrade

kskovpen · 2022-07-14T07:35:22Z

please test

cmsbuild · 2022-07-14T07:38:55Z

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26228/summary.html
COMMIT: 9e8924e
CMSSW: CMSSW_12_5_X_2022-07-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38733/26228/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26228/git-merge-result

srimanob · 2022-07-14T07:41:25Z

Don't you need also to test new wf of 140.001, 140.002?

kskovpen · 2022-07-14T07:42:30Z

Don't you need also to test new wf of 140.001, 140.002?

I do, but first I wanted to test the ones in upgrade setup. If all can be run at once with bot, please let me know.

kskovpen · 2022-07-14T07:45:00Z

test parameters:

workflow = 11634.602,140.001,140.002

kskovpen · 2022-07-14T07:45:37Z

please test

srimanob · 2022-07-14T07:49:39Z

You need to use

relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,cleanedupgrade,ged

srimanob · 2022-07-14T07:50:43Z

@cmsbuild please abort

cmsbuild · 2022-07-18T21:22:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38733/31122

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Don't recluster jets in HI miniAOD for Run 3 #38711, Add CPPF DQM modules #38564
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Add Run3 ALCA Express/Prompt workflow #38681, Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760, Ari changes #38758, Reorganize FastSim Run3 workflow #38660, Don't recluster jets in HI miniAOD for Run 3 #38711, Add CPPF DQM modules #38564
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Update BeamSpot in Run3 MC GTs + swap Run3RoundOptics25ns13TeVLowSigmaZ with Realistic25ns13p6TeVEarly2022Collision vtx smearing #38760, Clean up Phase-2 geometry (Up to D85) #38702, Reorganize FastSim Run3 workflow #38660, Add miniAODDQM FastSim Validation #38736, Add CPPF DQM modules #38564, Add run3 tracking low pu era #33532

cmsbuild · 2022-07-18T21:23:13Z

Pull request #38733 was updated. @jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again.

kskovpen · 2022-07-18T21:24:14Z

please test

cmsbuild · 2022-07-19T02:56:18Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd7be7/26314/summary.html
COMMIT: cc0f57c
CMSSW: CMSSW_12_5_X_2022-07-18-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38733/26314/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/11634.602_TTbar_14TeV+2021_NanoV10+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/140.001_RunMinimumBias2022+RunMinimumBias2022+HLTRUN3+RECONANORUN3+HARVESTRUN3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-cd7be7/140.002_RunZeroBias2022+RunZeroBias2022+HLTRUN3+RECONANORUN3+HARVESTRUN3

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3662417
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3662381
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

srimanob · 2022-07-19T19:57:37Z

+Upgrade

kskovpen · 2022-07-19T20:06:13Z

+pdmv

cmsbuild · 2022-07-19T20:06:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-07-20T10:22:00Z

+1

mariadalfonso · 2022-07-23T14:59:16Z

@kskovpen
we need a backport for 12_4 as when we start the production of the nanoV10 we want to check that we have this wf unmodified

kskovpen · 2022-07-23T15:10:17Z

@mariadalfonso , 140.001 and 140.002 wfs were a bit adjusted in #38830. Once the PR is merged, we will make a back port to 12_4.

add run3 wfs

9e8924e

cmsbuild added this to the CMSSW_12_5_X milestone Jul 14, 2022

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jul 14, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 14, 2022

cmsbuild added the requires-external label Jul 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 14, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 14, 2022

cmsbuild removed the requires-external label Jul 14, 2022

cmsbuild added tests-started and removed tests-rejected labels Jul 14, 2022

cmsbuild removed the tests-started label Jul 14, 2022

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved labels Jul 18, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 18, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 18, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 19, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 19, 2022

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jul 19, 2022

cmsbuild added orp-approved and removed orp-pending labels Jul 20, 2022

cmsbuild merged commit 2bf72f8 into cms-sw:master Jul 20, 2022

cmsbuild mentioned this pull request Jul 20, 2022

[DQM] Fix for bug in DT DQM at Online #38802

Merged

mmusich mentioned this pull request Sep 2, 2022

[12.4.X] Move DiMuonMassBiasClient to a regular harvesting path #39248

Merged

Add Run3 wfs (NanoV10) #38733

Add Run3 wfs (NanoV10) #38733

Uh oh!

Conversation

kskovpen commented Jul 14, 2022

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Jul 14, 2022

Uh oh!

cmsbuild commented Jul 14, 2022

Uh oh!

kskovpen commented Jul 14, 2022

Uh oh!

kskovpen commented Jul 14, 2022

Uh oh!

cmsbuild commented Jul 14, 2022

Uh oh!

srimanob commented Jul 14, 2022

Uh oh!

kskovpen commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kskovpen commented Jul 14, 2022

Uh oh!

kskovpen commented Jul 14, 2022

Uh oh!

srimanob commented Jul 14, 2022

Uh oh!

srimanob commented Jul 14, 2022

Uh oh!

cmsbuild commented Jul 18, 2022

Uh oh!

cmsbuild commented Jul 18, 2022

Uh oh!

kskovpen commented Jul 18, 2022

Uh oh!

cmsbuild commented Jul 19, 2022

Comparison Summary

Uh oh!

srimanob commented Jul 19, 2022

Uh oh!

kskovpen commented Jul 19, 2022

Uh oh!

cmsbuild commented Jul 19, 2022

Uh oh!

perrotta commented Jul 20, 2022

Uh oh!

mariadalfonso commented Jul 23, 2022

Uh oh!

kskovpen commented Jul 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kskovpen commented Jul 14, 2022 •

edited

Loading