CalibTracker/SiStripChannelGain: fix issue with ODR of stAPVGain struct

[mmusich]

resolves #38650

PR description:

Issue #38650 reported some compiler warnings of the type -Wodr in LTO_X IBs, as some elements defined multiple times within the same namespace leading to violation of the C++ One Definition Rule.
This is solved by making the class SiStripGainFromData use the struct stAPVGain defined in the APVGainStruct header.

PR validation:

cmssw compiles.
Run succesfully scram build use-ibeos runtests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38652/30936

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripChannelGain (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @robervalwalsh, @gbenelli, @tocheng, @alesaggio, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[tvami]

@cmsbuild , please test for CMSSW_12_5_LTO_X

[tvami]

type bugfix,trk

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9ca1/26082/summary.html
COMMIT: c0dd60f
CMSSW: CMSSW_12_5_LTO_X_2022-07-07-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38652/26082/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @ronchese HeavyFlavorAnalysis/*Decay redesigned using template interfaces #38524
• @alejands Correct subsystem folder for ecalgpu client #38579
• @mmusich update PrimaryVertexMonitor for Run-3 data-taking #38598
• @bsunanda Phase2-sim121 Prints out G4VSolid parameters to debug issues in scenarios created using DD4hep #38608
• @smuzaffar [LTO] do not remove lto flags for LTO IBs #38609
• @francescobrivio Update errorScale for BeamSpot Legacy DQM client #38632
• @watson-ij Modifiers not being set properly in EventConfig for data (GEM RecHits not in latest data) #38622
• @francescobrivio Fix DNS servers for BeamSpot DIP publication #38611
• @elusian Add DQM module using HeavyFlavorAnalysis for BPH common decays #38540
• @fabferro PPS pixel mask Bug Fix #38606

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9ca1/26082/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9ca1/26082/git-merge-result

Build

I found compilation error when building:

>> Subsystem DQM built
>> Entering Package src/BigProducts/Simulation
>> Building  big plugin tmp/el8_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so
lto-wrapper: warning: Extra option to -Xassembler: --compress-debug-sections, dropping all -Xassembler and -Wa options.
during IPA pass: icf
lto1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.
See  for instructions.
lto-wrapper: fatal error: /cvmfs/cms-ib.cern.ch/nweek-02740/el8_amd64_gcc10/external/gcc/10.3.0-84898dea653199466402e67d73657f10/bin/c++ returned 1 exit status
compilation terminated.


[mmusich]

Subsystem DQM built
>> Entering Package src/BigProducts/Simulation
>> Building big plugin tmp/el8_amd64_gcc10/src/BigProducts/Simulation/pluginSimulation.so
lto-wrapper: warning: Extra option to -Xassembler: --compress-debug-sections, dropping all -Xassembler and -Wa options.
during IPA pass: icf

I don't think this is related...

[tvami]

Yes, let's just wait for the standard el8_amd64_gcc10 tests to finish, and I'll ignore the LTO build failure

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38652/30939

• This PR adds an extra 44KB to repository

[cmsbuild]

Pull request #38652 was updated. @malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

[mmusich]

please test

[tvami]

@mmusich I'm confused on why the other PR's @cmsbuild , please test for CMSSW_12_5_LTO_X worked, and why it doesnt work here, should we try that again?

[mmusich]

should we try that again?

no, it might be this PR is pulling in other dependencies that don't compile.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc9ca1/26085/summary.html
COMMIT: 0441677
CMSSW: CMSSW_12_5_X_2022-07-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38652/26085/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654999
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654975
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• diffs in MTD only
• PR is according to the PR description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1