Fix PR #38437 to disable mkFit in pixelLessStep

[mmasciov]

PR description:

This PR offers a fix to PR #38437, that disables mkFit for pixelLessStep, so that the new era is fully recognized.

PR validation:

Standard MTV for SoftQCD (PU=0) sample:
http://uaf-10.t2.ucsd.edu/~mmasciov/MIC/SoftQCD/MTV_SoftQCD_PRFix/

Denominator (blue): default Run3 era
cmsDriver.py step3 --conditions auto:phase1_2022_realistic -s RAW2DIGI,RECO:reconstruction_trackingOnly,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM --datatier DQMIO -n 5000 --geometry DB:Extended --era Run3 --eventcontent DQM --no_exec --filein file:/data2/mmasciov/SoftQCD/CMSSW_12_4_0_pre4/src/step2.root --fileout step3_SoftQCD_default.root --python_filename step3_SoftQCD_default.py --nThreads 8

Numerator (red): Run3_ckfPixelLessSttep era
cmsDrivery.py step3 --conditions auto:phase1_2022_realistic -s RAW2DIGI,RECO:reconstruction_trackingOnly,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM --datatier DQMIO -n 5000 --geometry DB:Extended --era Run3_ckfPixelLessStep --eventcontent DQM --no_exec --filein file:/data2/mmasciov/SoftQCD/CMSSW_12_4_0_pre4/src/step2.root --fileout step3_SoftQCD_ckfPixelLess.root --python_filename step3_SoftQCD_ckfPixelLess.py --nThreads 8

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38565/30814

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Era_Run3_ckfPixelLessStep_cff.py modified in PR(s): Add new Run3_ckfPixelLessStep to StandardSequences #38563
  • File Configuration/Eras/python/Era_Run3_ckfPixelLessStep.py modified in PR(s): Add new Run3_ckfPixelLessStep to StandardSequences #38563
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): [PPS] Direct simulation as sequence #38280, Add new Run3_ckfPixelLessStep to StandardSequences #38563, Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

• Configuration/Eras (operations)
• Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

duplicate of #38563

[mmusich]

@mmasciov please add a wf to runTheMatrix so that it can tested.
Thanks.

[tvami]

urgent

[tvami]

type bugfix

[mmusich]

please add a wf to runTheMatrix so that it can tested.

In case it helps:

diff --git a/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py b/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
index 9ab9381e003..9bf5859d218 100644
--- a/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
+++ b/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
@@ -379,6 +379,27 @@ upgradeWFs['trackingMkFit'].step3 = {
     '--procModifiers': 'trackingMkFit'
 }
 
+# NoMkFitPixelLess workflows
+class UpgradeWorkflow_NoMkFitPixelLess(UpgradeWorkflow):
+    def setup_(self, step, stepName, stepDict, k, properties):
+        stepDict[stepName][k] = merge([{'--era': 'Run3_ckfPixelLessStep'}, stepDict[step][k]])
+    def condition(self, fragment, stepList, key, hasHarvest):
+        return fragment=="TTbar_14TeV" and '2021' in key
+upgradeWFs['NoMkFitPixelLess'] = UpgradeWorkflow_NoMkFitPixelLess(
+    steps = [
+        'Reco',
+        'RecoNano',
+        'RecoGlobal',
+    ],
+    PU = [
+        'Reco',
+        'RecoNano',
+        'RecoGlobal',
+    ],
+    suffix = '_NoMkFitPixelLess',
+    offset = 0.71,
+)
+
 #DeepCore seeding for JetCore iteration workflow
 class UpgradeWorkflow_seedingDeepCore(UpgradeWorkflow):
     def setup_(self, step, stepName, stepDict, k, properties):

this seems to work..

[mmasciov]

@mmusich, just added a commit with this. Sorry for the delay.

[mmusich]

test parameters:

• workflows = 11634.71, 11634.72

[mmusich]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38565/30817

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): [PPS] Direct simulation as sequence #38280, Add run3 tracking low pu era #33532

[cmsbuild]

Pull request #38565 was updated. @perrotta, @jordan-martins, @bbilin, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

[jordan-martins]

+1

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aecc63/25916/summary.html
COMMIT: e6ea952
CMSSW: CMSSW_12_5_X_2022-06-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38565/25916/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aecc63/11634.71_TTbar_14TeV+2021_trackingRun3CkfPixelLessStep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aecc63/11634.72_TTbar_14TeV+2021_trackingOnlyRun3CkfPixelLessStep+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654586
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654562
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

Can we bypass upgrade here? It has nothing to do with it.

[perrotta]

Can we bypass upgrade here? It has nothing to do with it.

That was indeed my intention. But I wanted to look at the logs of the newly defined wfs first, at least. No specific issues reported, let merge this in master then

By the way @mmusich : while looking at the logs I noticed the following warning (unrelated to this fix) that you may be interested in:

%MSG
%MSG-e TkDetLayers:   TrackerRecoGeometryESProducer:TrackerRecoGeometryESProducer@callESModule  30-Jun-2022 16:12:20 CEST Run: 1 Stream: 0
 ForwardDiskSectorBuilderFromDet: Trying to build Petal Wedge from Dets at different z positions !! Delta_z = -0.951241
%MSG

[perrotta]

+1

[perrotta]

merge
(this fix is not related to upgrade)

[AdrianoDee]

+1
(Just to remove the label, this actually has nothing to do with upgrade)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

[mmusich]

@perrotta

while looking at the logs I noticed the following warning (unrelated to this fix) that you may be interested in

See #34476. In short, wontfix.