fix `VectorHits` workflows with PU [12.4.X] #38469

mmusich · 2022-06-22T13:43:45Z

backport of #38468

PR description:

it was noticed by @JanFSchulte that running wf 39634.9 it was crashing on the harvesting step with a seg fault in Phase2ITRecHitHarvester:Phase2OTTrackingRechitHarvester_PS.
This happens because this protection:

cmssw/Validation/SiTrackerPhase2V/python/Phase2TrackerMCHarvesting_cff.py

Lines 70 to 71 in c3498e8

    
           from Configuration.ProcessModifiers.vectorHits_cff import vectorHits 
        
           vectorHits.toReplaceWith(trackerphase2ValidationHarvesting, trackerphase2ValidationHarvesting.copyAndExclude([Phase2OTTrackingRechitHarvester_PS,Phase2OTTrackingRechitHarvester_2S]))

was not picked up, as the modifier was not applied in the harvesting step.
This PR trivially fixes the problem.

PR validation:

Run the wf 39634.9 and I get:

39634.9 2026D88PU_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU [1]: cmsDriver.py TTbar_14TeV_TuneCP5_cfi  -s GEN,SIM -n 10 --conditions auto:phase2_realistic_T21 --beamspot HLLHC14TeV --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry Extended2026D88 --era Phase2C17I13M9 --relval 9000,100 
                                           [2]: cmsDriver.py step2  -s DIGI:pdigi_valid,L1TrackTrigger,L1,DIGI2RAW,HLT:@fake2 --conditions auto:phase2_realistic_T21 --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry Extended2026D88 --era Phase2C17I13M9 --pileup AVE_200_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_12_3_0_pre5-123X_mcRun4_realistic_v4_2026D88noPU-v1/GEN-SIM
                                           [3]: cmsDriver.py step3  -s RAW2DIGI,RECO,RECOSIM,PAT,VALIDATION:@phase2Validation+@miniAODValidation,DQM:@phase2+@miniAODDQM --conditions auto:phase2_realistic_T21 --datatier GEN-SIM-RECO,MINIAODSIM,DQMIO -n 10 --eventcontent FEVTDEBUGHLT,MINIAODSIM,DQM --geometry Extended2026D88 --era Phase2C17I13M9 --procModifiers vectorHits --pileup AVE_200_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_12_3_0_pre5-123X_mcRun4_realistic_v4_2026D88noPU-v1/GEN-SIM
                                           [4]: cmsDriver.py step4  -s HARVESTING:@phase2Validation+@phase2+@miniAODValidation+@miniAODDQM --conditions auto:phase2_realistic_T21 --mc  --geometry Extended2026D88 --scenario pp --filetype DQM --era Phase2C17I13M9 --procModifiers vectorHits -n 10 --pileup AVE_200_BX_25ns --pileup_input das:/RelValMinBias_14TeV/CMSSW_12_3_0_pre5-123X_mcRun4_realistic_v4_2026D88noPU-v1/GEN-SIM

as expected (notice the modifier gets added to the step4).

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38468

cmsbuild · 2022-06-22T13:44:10Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @fabiocos, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from fix VectorHits workflows with PU #38468

mmusich · 2022-06-22T13:47:31Z

type bug-fix

mmusich · 2022-06-22T18:34:57Z

please test

cmsbuild · 2022-06-22T22:21:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68c36f/25706/summary.html
COMMIT: e943bdd
CMSSW: CMSSW_12_4_X_2022-06-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38469/25706/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3680359
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3680323
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

AdrianoDee · 2022-06-24T09:34:04Z

please test workflow 39634.9

AdrianoDee · 2022-06-24T09:36:13Z

please abort

AdrianoDee · 2022-06-24T09:41:19Z

test parameters:

workflow = 39634.9
relvals_opt = -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

AdrianoDee · 2022-06-24T16:59:22Z

please test

cmsbuild · 2022-06-24T20:48:41Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68c36f/25770/summary.html
COMMIT: e943bdd
CMSSW: CMSSW_12_4_X_2022-06-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38469/25770/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3680359
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3680329
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

mmusich · 2022-06-27T08:34:18Z

test parameters:

workflow = 39634.9
relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,cleanedupgrade,ged

mmusich · 2022-06-27T08:34:25Z

please test

cmsbuild · 2022-06-27T17:53:23Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68c36f/25827/summary.html
COMMIT: e943bdd
CMSSW: CMSSW_12_4_X_2022-06-27-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38469/25827/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
39634.9 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-68c36f/39634.9_TTbar_14TeV+2026D88PU_vectorHits+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTriggerPU+RecoGlobalPU+HARVESTGlobalPU

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3675241
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3675217
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 212 log files, 49 edm output root files, 50 DQM output files
TriggerResults: no differences found

perrotta · 2022-06-27T21:28:02Z

https://github.com/orgs/cms-sw/teams/pdmv-l2 https://github.com/orgs/cms-sw/teams/upgrade-l2 is this needed for 12_4_1?

AdrianoDee · 2022-06-27T22:04:49Z

@perrotta from
upgrade point of view I don't see it as strictly necessary, given the R&D flavor of the wf. But maybe @mmusich has some reason to have it. Anyway it's an easy sign-off now the tests have run successfully.

AdrianoDee · 2022-06-27T22:06:04Z

+upgrade

Fixing vector hits wf ´39634.9´

mmusich · 2022-06-28T05:21:26Z

some reason to have it.

The "feature" was discovered in this cycle. This PR is mostly for convenience, but it is by no means mandatory. On the other hand I think the fix is trivial and uncontroversial.

perrotta · 2022-06-28T08:05:38Z

@cms-sw/pdmv-l2 if you agree with including this simple fix in 12_4_1, could you please sign it?

kskovpen · 2022-06-28T08:09:18Z

+pdmv

cmsbuild · 2022-06-28T08:09:37Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-28T08:15:01Z

+1

fix VH workflows with PU

e943bdd

cmsbuild added this to the CMSSW_12_4_X milestone Jun 22, 2022

cmsbuild added backport orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Jun 22, 2022

cmsbuild added the bug-fix label Jun 22, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 22, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 22, 2022

cmsbuild added tests-started and removed tests-approved labels Jun 24, 2022

cmsbuild added tests-pending and removed tests-started labels Jun 24, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 24, 2022

cmsbuild added tests-started backport-ok and removed tests-approved backport labels Jun 27, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 27, 2022

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 27, 2022

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jun 28, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 28, 2022

cmsbuild merged commit e7910fa into cms-sw:CMSSW_12_4_X Jun 28, 2022

mmusich deleted the fixVHWofkFlowWithPU_12_4_X branch July 2, 2022 08:49

	from Configuration.ProcessModifiers.vectorHits_cff import vectorHits
	vectorHits.toReplaceWith(trackerphase2ValidationHarvesting, trackerphase2ValidationHarvesting.copyAndExclude([Phase2OTTrackingRechitHarvester_PS,Phase2OTTrackingRechitHarvester_2S]))

fix VectorHits workflows with PU [12.4.X] #38469

fix VectorHits workflows with PU [12.4.X] #38469

Uh oh!

Conversation

mmusich commented Jun 22, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Jun 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Jun 22, 2022

Uh oh!

mmusich commented Jun 22, 2022

Uh oh!

cmsbuild commented Jun 22, 2022

Comparison Summary

Uh oh!

AdrianoDee commented Jun 24, 2022

Uh oh!

AdrianoDee commented Jun 24, 2022

Uh oh!

AdrianoDee commented Jun 24, 2022

Uh oh!

AdrianoDee commented Jun 24, 2022

Uh oh!

cmsbuild commented Jun 24, 2022

Comparison Summary

Uh oh!

mmusich commented Jun 27, 2022

Uh oh!

mmusich commented Jun 27, 2022

Uh oh!

cmsbuild commented Jun 27, 2022

Comparison Summary

Uh oh!

perrotta commented Jun 27, 2022

Uh oh!

AdrianoDee commented Jun 27, 2022

Uh oh!

AdrianoDee commented Jun 27, 2022

Uh oh!

mmusich commented Jun 28, 2022

Uh oh!

perrotta commented Jun 28, 2022

Uh oh!

kskovpen commented Jun 28, 2022

Uh oh!

cmsbuild commented Jun 28, 2022

Uh oh!

perrotta commented Jun 28, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fix `VectorHits` workflows with PU [12.4.X] #38469

fix `VectorHits` workflows with PU [12.4.X] #38469

cmsbuild commented Jun 22, 2022 •

edited

Loading