[backport to 12_4_X] Change at CaloLayer1 DQM the filling threshold for ECAL 5BX plots

[hftsoi]

PR description:

This PR is to modify the CaloLayer1 DQM, raising the TP energy threshold for filling the FAT event histograms for ECAL's pre-firing studies. The old threshold has been at 1 GeV, which is too low and the plots are dominated by detector noise seen in previous cosmic runs. The new threshold is set at 4 GeV, which should be well above the average noise levels reported by ECAL. Filling conditions are also added to be consistent with normal events filling, i.e. do not fill if there is problematic tower masked etc.

PR validation:

The codes are tested by running offline DQM on recent runs with unstable beams collisions, which has more high energy TPs to see the real effects. The DQM plots are properly filled and the ECAL experts are satisfied with this modification.

if this PR is a backport please specify the original PR and why you need to backport that PR:

PR to master (12_5_X): #38361
Backport to current online DQM release (12_3_5_patch1): #38399 which has been in DQM production
This PR is to backport to 12_4_X

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for CMSSW_12_4_X.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Change at CaloLayer1 DQM the filling threshold for ECAL 5BX plots #38361

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-432910/25604/summary.html
COMMIT: 0b04a3c
CMSSW: CMSSW_12_4_X_2022-06-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38414/25604/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3680359
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3680323
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

backport of #38361

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1