[EGM MVA ID] xml.gz to root conversion

[swagata87]

PR description:

This is a technical PR, and no change in physics is expected.
This is aimed at addressing the github issue #37867 (and also #38089, which is basically the same). The needed functionality is recently provided via #38091 , which was merged some days ago.

Electron MVA ID's xml.gz files are converted to .root files by using convertXMLToGBRForestROOT.
This PR requires this external: cms-data/RecoEgamma-ElectronIdentification#26

PR validation:

Tested with workflow 11834.21.

This PR is not a backport.
Backport not necessary.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38339/30520

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master.

It involves the following packages:

• RecoEgamma/ElectronIdentification (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @valsdav, @lgray, @sobhatta, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[swagata87]

enable profiling

[swagata87]

please test with cms-data/RecoEgamma-ElectronIdentification#26

[swagata87]

type egamma

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068aba/25452/summary.html
COMMIT: db56edf
CMSSW: CMSSW_12_5_X_2022-06-11-1100/el8_amd64_gcc10
Additional Tests: PROFILING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38339/25452/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Run3-gex135B Try to use MessageLogger instead of cout in SimG4CMS/FP420 #38306

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068aba/25452/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-068aba/25452/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
136.8562 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3658678
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3658648
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

before:

after:

looks like it does have a noticeable effect in NANO startup, great!

[jpata]

+reconstruction

• technical performance improvement
• addresses convert MVA models for electronMVAValueMapProducer from XML to ROOT #37867
• requires Convert xml.gz files to .root files cms-data/RecoEgamma-ElectronIdentification#26

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[swagata87]

looks like it does have a noticeable effect in NANO startup, great!

okay, good to see improvement.
maybe at some point we can also do the same for photon ID xml files, which lives here: https://github.com/cms-data/RecoEgamma-PhotonIdentification/tree/master/MVA/Fall17 in cms-data.
But for photons, we have only very few xmls, so maybe it won't bring much improvement.

[perrotta]

+1

[perrotta]

+1