Skip to content

Conversation

@tvami
Copy link
Contributor

@tvami tvami commented Jun 10, 2022

PR description:

See #38324

PR validation:

test parameters:
  - workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38324

@tvami
Copy link
Contributor Author

tvami commented Jun 10, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@tvami tvami changed the title Updating EGM regression tags and conditions for the L1 EMTF and CALO tags for Run-3 MCs [12_4_X] Updating EGM regression tags and conditions for the L1 EMTF and CALO tags for Run-3 MCs Jun 10, 2022
@cmsbuild cmsbuild added this to the CMSSW_12_4_X milestone Jun 10, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 10, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jun 10, 2022

Backport of #38324

@tvami
Copy link
Contributor Author

tvami commented Jun 10, 2022

type l1t,egamma

@tvami
Copy link
Contributor Author

tvami commented Jun 10, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad734/25437/summary.html
COMMIT: 0d11888
CMSSW: CMSSW_12_4_X_2022-06-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38325/25437/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad734/25437/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dad734/25437/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dad734/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dad734/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4151675
  • DQMHistoTests: Total failures: 8755
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4142898
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 227 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: found differences in 8 / 53 workflows

@malbouis
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 12, 2022

+1

@cmsbuild cmsbuild merged commit 277fd82 into cms-sw:CMSSW_12_4_X Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants