Disabled looper reconstruction in HI Eras for Run3_pp_on_PbPb and Run2…

[sayanchatterjee38]

PR description:

Title: Disabled looper reconstruction in HI Eras for Run 3_pp_on_PbPb and Run2_2018_pp_on_AA

Description: This PR has disabled looper reconstruction from HI Eras after checking timing and CPU usage, tracking efficiency, fake, multiple, non-primary reconstructions fractions for peripheral and central events. Also, the same checks were performed in the MinimumBias dataset produced for 1000 events. Please, see slides 1-9 from here [1].

No significant changes were observed in event and track variables while removing the No-Looper condition except for the Hit count distribution.

An issue had been raised already regarding disabling looper reconstruction for HeavyIons. Please look here [2] for detail.

Link for the HI Trackin POG:
[1] https://indico.cern.ch/event/1153062/contributions/4841907/attachments/2429416/4159748/NoLooper_HITracking.pdf

Link for the issue:
[2] #35758

PR validation:

Run time observations and a detailed study of each track variable have been performed with enabling and disabling trackingNoLoopers. We have also performed a detailed comparison of tracking efficiency, fake, multiple, and nonprimary reconstruction fractions for central, peripheral, and minimum bias events with enabling and disabling trackingNoLoopers.

If this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cc: @mandrenguyen, @abaty, @CesarBernardes

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38288/30445

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38288/30445/cms-checkout-topic.log

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38288/30446

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Eras/python/Era_Run2_2018_pp_on_AA_cff.py modified in PR(s): Adding HZZ electron MVA ID #37429
  • File Configuration/Eras/python/Era_Run3_pp_on_PbPb_cff.py modified in PR(s): Adding HZZ electron MVA ID #37429

[cmsbuild]

A new Pull Request was created by @sayanchatterjee38 (SAYAN CHATTERJEE) for master.

It involves the following packages:

• Configuration/Eras (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type tracking

[mmusich]

assign reconstruction

[mmusich]

please test

[cmsbuild]

New categories assigned: reconstruction

@jpata,@slava77,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21c301/25365/summary.html
COMMIT: 03b8efa
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38288/25365/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @thomreis ECAL - Fix dereferencing of nullptr in CaloRectangleRange #38173
• @fwyzard ECAL GPU unpacker: adapt the buffer size to the ECAL FEDs size #38202
• @bsunanda Run3-gex135A Try to avoid compilation warnings in MagneticField/GeomBuilder #38247

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21c301/25365/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21c301/25365/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 745 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 220
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3651836
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

If I recall correctly, the discussion in the previous PR was if this should also be disabled for the other years in Run2.
Reco preference is to have the configurations as similar as possible across different eras (unless there are good physics reasons).
On the other hand, in the end it's only the HI group who will be consuming these data, and if there's no capacity or reason to recheck the older periods, I wouldn't push on it too hard. So if you and the tracking POG confirm that doing only 2018+Run3 is fine, I have no objection and will sign it.

[mmusich]

So if you and the tracking POG confirm that doing only 2018+Run3 is fine, I have no objection and will sign it.

I think the PR as is can go, but it would still be nice to check on the other periods and adjust accordingly if possible.

[abaty]

Hi Marco, Joosep,

From my side, I think it is best if we could focus our efforts in the HI tracking group on getting everything ready for Run 3 at the moment. Checking the earlier eras will take a little time, so I would suggest we proceed forward with this PR for now and then revisit the other earlier, lower priority, eras at a later date. Perhaps we could create an issue on github so that we do not forget in the future?

[mmusich]

@abaty,

I think it is best if we could focus our efforts in the HI tracking group on getting everything ready for Run 3 at the moment.

Sure that's the spirit of my earlier comment #38288 (comment).

Perhaps we could create an issue on github so that we do not forget in the future?

There's already an open issue about it: #35758.
It can be updated to reflect the current status after this PR

[jpata]

+reconstruction

• looper reco disabled for Run2_2018 and Run3
• reco differences expected and observed in HI workflows for tracks and everything downstream of tracks

[qliphy]

+1
to follow up with #35758.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.