Skip to content

Conversation

@nurfikri89
Copy link
Contributor

Backport from #37744

PR description:

This PR sets the AK4 Puppi jet collection as the default AK4 jet collection for Run 3 NanoAOD production. The AK4 Puppi jet collection is retrieved from MiniAOD (slimmedJetsPuppi) and are saved in the Jet table in NanoAODs, although with less variables stored, compared to AK4 CHS jets, due to the unavailable trainings for PileUp Id, Quark-Gluon Likelihood and b-jet/c-jet energy regression.

The reco jet configurations have been split up into three different cff files. Two new cff files for AK4 Puppi jets (jetsAK4_Puppi_cff.py) and AK8 Puppi jets (jetsAK8_cff.py) with jets_cff.py renamed to jetsAK4_CHS_cff.py. All AK8 Puppi related configurations in jets_cff.py are moved to jetsAK8_cff.py. For Run 2 compatibility, Run 2 modifiers are set up in various files to switch from AK4 Puppi jets to AK4 CHS jets. Some housekeeping were also done like moving the AK4 and AK8 DeepInfo functions and switches from nano_cff.py to jetsAK4_CHS_cff.py and jetsAK8_cff.py.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2022

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_12_4_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-56b7bb/25224/summary.html
COMMIT: 75c2dad
CMSSW: CMSSW_12_4_X_2022-06-02-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38207/25224/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3669993
  • DQMHistoTests: Total failures: 914
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3669056
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

backport inline with master

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@mariadalfonso
Copy link
Contributor

backport of #37744

@qliphy
Copy link
Contributor

qliphy commented Jun 4, 2022

+1

@cmsbuild cmsbuild merged commit bedc8e5 into cms-sw:CMSSW_12_4_X Jun 4, 2022
lauridsj added a commit to lauridsj/cmssw that referenced this pull request Aug 8, 2022
@nurfikri89 nurfikri89 deleted the portFrom125XTo124X_nano_jetsrun3_forPR branch January 11, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants