Skip to content

Conversation

@SiewYan
Copy link
Contributor

@SiewYan SiewYan commented May 21, 2022

PR description:

This PR trying to address the EDM addition in #37187 , using advises from twiki [*].
The HepMC3 package adapted new strategy to manipulate event records of High Energy Physics Monte Carlo Event Generators (MCEGs) [**], notably:

  1. Particles and vertices are stored separately in an ordered graph structure; all custom iterators were removed.
  2. Extension on the I/O functionality of the library.

[*] https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts
[**] https://iopscience.iop.org/article/10.1088/1742-6596/1525/1/012017/pdf

The HepMC3 new data format poses challenges on defining the corresponding EDMProduct definition.

This PR depicts partial implementation, due to some technical error:

Error: Class shared_ptr<HepMC3::GenParticle> has been selected but currently the support for its I/O is not yet available. Note that shared_ptr<HepMC3::GenParticle>, even if not selected, will be available for interpreted code.
Error: Class shared_ptr<HepMC3::GenVertex> has been selected but currently the support for its I/O is not yet available. Note that shared_ptr<HepMC3::GenVertex>, even if not selected, will be available for interpreted code.

I am looking for advice(s) on how to solve the error. @smuzaffar, @mkirsano

Note: class version will be done accordingly after a successful compilation with the amended version classes_def.xml.

Related Issue/PR:

  1. Issue Migrate CMSSW from HepMC2 to HepMC3 #36662
  2. configure pythia8 to use hepmc3: #7677
  3. Add generator hepmc3 products #37187
  4. Add HepMC3 products and methods to Generator base clases #37689
  5. Add to Pythia8Interface the plugin that produces HepMC3 products #37753

PR validation:

No validation yet, to be finalized as the PR evolve..

if this PR is a backport please specify the original PR and why you need to backport that PR:

NA

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/30110

@cmsbuild
Copy link
Contributor

cmsbuild commented May 21, 2022

A new Pull Request was created by @SiewYan (Siewyan Hoh 何守仁) for master.

It involves the following packages:

  • SimDataFormats/GeneratorProducts (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@apsallid, @rovere, @bsunanda, @lecriste, @ebrondol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@SiewYan
Copy link
Contributor Author

SiewYan commented May 21, 2022

FYI: @imranyusuff

@SiewYan
Copy link
Contributor Author

SiewYan commented May 21, 2022

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/24892/summary.html
COMMIT: 13c562c
CMSSW: CMSSW_12_5_X_2022-05-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38033/24892/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/LHEXMLStringProduct.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/hepmc_rootio.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/HepEvt.F
Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code.
Error: Class shared_ptr has been selected but currently the support for its I/O is not yet available. Note that shared_ptr, even if not selected, will be available for interpreted code.
gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc] Error 1
>> Compiling LCG dictionary: tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc
c++: error: SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc: No such file or directory
c++: fatal error: no input files
compilation terminated.
gmake: *** [tmp/el8_amd64_gcc10/src/SimDataFormats/GeneratorProducts/src/SimDataFormatsGeneratorProducts/a/SimDataFormatsGeneratorProducts_xr.cc.o] Error 1


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... started
>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package SimDataFormats/GeneratorProducts
>> Compile sequence completed for CMSSW CMSSW_12_5_X_2022-05-21-1100
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/tmp/el8_amd64_gcc10/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package SimDataFormats/GeneratorProducts
Entering library rule at SimDataFormats/GeneratorProducts
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_5_X_2022-05-21-1100/src/SimDataFormats/GeneratorProducts/src/GenEventInfoProduct.cc


@SiewYan
Copy link
Contributor Author

SiewYan commented Jul 26, 2022

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38033/31271

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

Milestone for this pull request has been moved to CMSSW_15_1_X. Please open a backport if it should also go in to CMSSW_15_0_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2025

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/44255/summary.html
COMMIT: 21e1444
CMSSW: CMSSW_15_0_X_2025-02-06-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38033/44255/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10e534/44255/git-merge-result

@mkirsano
Copy link
Contributor

mkirsano commented Feb 7, 2025

Please close this PR, it is obsolete and not needed anymore

@srimanob
Copy link
Contributor

@SiewYan
Would you mind to close the PR? Sorry to bug you.

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_16_1_X. Please open a backport if it should also go in to CMSSW_16_0_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_16_0_X, CMSSW_16_1_X Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants