Skip to content

Conversation

@FHead
Copy link
Contributor

@FHead FHead commented May 11, 2022

This is the backport to CMSSW 11_2_X of PR #36489
More information can be found in the original PR.

It addresses issue #37841.

It passed basic matrix tests

@mandrenguyen

This is to prepare the backport to CMSSW 11_2_X of this PR cms-sw#36489
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @FHead (Yi Chen) for CMSSW_11_2_X.

It involves the following packages:

  • RecoHI/HiJetAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented May 12, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-659fe4/24637/summary.html
COMMIT: 1a5d376
CMSSW: CMSSW_11_2_X_2022-05-08-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37913/24637/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 270 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2537235
  • DQMHistoTests: Total failures: 1886
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2535327
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@clacaputo
Copy link
Contributor

Hi @FHead and @mandrenguyen , do we need to put this change behind a modifier? You mentioned (#37841 ) that this PR is needed for "partial reprocessing" some PbPb data and MC, so there are going to be some discrepancies between dataset/samples, produced with two different versions of the reconstruction code

@mandrenguyen
Copy link
Contributor

@clacaputo So you would like to dedicated process modifier for the two backports, specifically for this reprocessing?

@clacaputo
Copy link
Contributor

Hi @mandrenguyen, having a modifier would be ideal

@mandrenguyen
Copy link
Contributor

@clacaputo I have created a process modifier in #37984
If that works for you, we can close this PR, since it's already included there.

@FHead
Copy link
Contributor Author

FHead commented May 24, 2022

Since this is covered in #37984, I will close this one

@FHead FHead closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants