Drop references to legacy MC generators (see cms-sw/cmsdist#7763) #37569

iarspider · 2022-04-14T11:47:58Z

PR description:

Drop references to legacy MC generators - see cms-sw/cmsdist#7763 a list of dropped generators.

iarspider · 2022-04-14T11:48:40Z

please test with cms-sw/cmsdist#7763

cmsbuild · 2022-04-14T11:55:26Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37569/29306

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Herwig6Interface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568
- File GeneratorInterface/HydjetInterface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568
- File GeneratorInterface/PomwigInterface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37569/29306/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37569/29306/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-04-14T12:05:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37569/29307

This PR adds an extra 28KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Herwig6Interface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568
- File GeneratorInterface/HydjetInterface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568
- File GeneratorInterface/PomwigInterface/BuildFile.xml modified in PR(s): Fixing missing Buildfile dependencies on hepmc #37568

cmsbuild · 2022-04-14T12:05:54Z

A new Pull Request was created by @iarspider for master.

It involves the following packages:

Configuration/Generator (generators)
FWCore/Concurrency (core)
GeneratorInterface/CascadeInterface (generators)
GeneratorInterface/Herwig6Interface (generators)
GeneratorInterface/HydjetInterface (generators)
GeneratorInterface/MCatNLOInterface (generators)
GeneratorInterface/PhotosInterface (generators)
GeneratorInterface/PomwigInterface (generators)
PhysicsTools/JetMCAlgos (analysis)
TopQuarkAnalysis/TopEventProducers (analysis)

@SiewYan, @smuzaffar, @Dr15Jones, @mkirsano, @makortel, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez, @santocch can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @mkirsano, @missirol, @makortel, @cbaus, @wddgit, @Martin-Grunewald, @JyothsnaKomaragiri, @alberto-sanchez, @andrzejnovak, @demuller, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

iarspider · 2022-04-14T12:11:19Z

please test with cms-sw/cmsdist#7763

cmsbuild · 2022-04-14T12:50:25Z

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23913/summary.html
COMMIT: fb27cb3
CMSSW: CMSSW_12_4_X_2022-04-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37569/23913/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23913/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23913/git-merge-result

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

tmp/slc7_amd64_gcc10/MakeData/DirCache.mk:2218: No such file exists: src/GeneratorInterface/Herwig6Interface/test/H4muAnalyzer.cc. Please fix src/GeneratorInterface/Herwig6Interface/test/BuildFile.
tmp/slc7_amd64_gcc10/MakeData/DirCache.mk:2250: No such file exists: src/GeneratorInterface/HydjetInterface/test/HydjetAnalyzer.cc. Please fix src/GeneratorInterface/HydjetInterface/test/BuildFile.
tmp/slc7_amd64_gcc10/MakeData/DirCache.mk:2321: No such file exists: src/GeneratorInterface/MCatNLOInterface/test/ZeeAnalyzer.cc. Please fix src/GeneratorInterface/MCatNLOInterface/test/BuildFile.
tmp/slc7_amd64_gcc10/MakeData/DirCache.mk:2337: No such file exists: src/GeneratorInterface/PomwigInterface/test/*.cc. Please fix src/GeneratorInterface/PomwigInterface/test/BuildFile.
>> Local Products Rules ..... started
gmake: *** [src/GeneratorInterface/CascadeInterface/plugins contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1
gmake: *** [src/GeneratorInterface/Herwig6Interface/plugins contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1
gmake: *** [src/GeneratorInterface/HydjetInterface/plugins contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1
gmake: *** [src/GeneratorInterface/MCatNLOInterface/plugins contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1
gmake: *** [src/GeneratorInterface/PomwigInterface/plugins contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1
gmake: *** [src/GeneratorInterface/Herwig6Interface/test contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1

iarspider · 2022-04-14T12:58:16Z

test parameters:

full_cmssw: true

iarspider · 2022-04-14T12:58:37Z

please test with cms-sw/cmsdist#7763

iarspider · 2022-04-14T12:58:49Z

please abort

iarspider · 2022-04-14T12:59:03Z

test parameters:

full_cmssw=true

iarspider · 2022-04-14T12:59:20Z

please test with cms-sw/cmsdist#7763

cmsbuild · 2022-04-14T16:12:55Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23918/summary.html
COMMIT: fb27cb3
CMSSW: CMSSW_12_4_X_2022-04-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37569/23918/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23918/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8aee32/23918/git-merge-result

RelVals

9.0

----- Begin Fatal Exception 14-Apr-2022 17:06:06 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=Pythia6GeneratorFilter label='generator'
Exception Message:
Unable to find plugin 'Photos2155' in category 'PhotosFactory'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

iarspider · 2022-04-19T08:35:49Z

As suggested by @smuzaffar, splitting this PR into several small ones to simplify the review process.

Drop references to legacy MC generators (see cms-sw/cmsdist#7763)

e321316

cmsbuild added this to the CMSSW_12_4_X milestone Apr 14, 2022

cmsbuild added analysis-pending code-checks-pending core-pending generators-pending orp-pending pending-signatures tests-pending labels Apr 14, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Apr 14, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Apr 14, 2022

Apply code-style

fb27cb3

cmsbuild added code-checks-pending tests-pending and removed tests-started requires-external code-checks-rejected labels Apr 14, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 14, 2022

cmsbuild added requires-external tests-started and removed tests-pending labels Apr 14, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 14, 2022

cmsbuild added tests-pending and removed tests-rejected labels Apr 14, 2022

cmsbuild added tests-rejected tests-started and removed tests-pending tests-rejected labels Apr 14, 2022

cmsbuild added tests-rejected and removed tests-started labels Apr 14, 2022

iarspider closed this Apr 19, 2022

iarspider mentioned this pull request Apr 19, 2022

Remove Configuration/Generator/data/download.url #37610

Merged

iarspider deleted the drop_legacy_generator_interfaces branch February 27, 2024 10:16

Drop references to legacy MC generators (see cms-sw/cmsdist#7763) #37569

Drop references to legacy MC generators (see cms-sw/cmsdist#7763) #37569

Uh oh!

Conversation

iarspider commented Apr 14, 2022

PR description:

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

cmsbuild commented Apr 14, 2022

Uh oh!

cmsbuild commented Apr 14, 2022

Uh oh!

cmsbuild commented Apr 14, 2022

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

cmsbuild commented Apr 14, 2022

Clang Build

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

iarspider commented Apr 14, 2022

Uh oh!

cmsbuild commented Apr 14, 2022

RelVals

Uh oh!

iarspider commented Apr 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants