Skip to content

Conversation

@seungjin-yang
Copy link
Contributor

@seungjin-yang seungjin-yang commented Apr 8, 2022

PR description:

Backport of #37341. This PR adds DQM modules (GEMCSCSegmentSource and GEMCSCSegmentClient) to monitor GE1/1 detection efficiency using GEMCSCSegment in the online DQM.

PR validation:

This PR was tested with the following recipe on lxplus.

cmsrel CMSSW_12_3_X_2022-04-06-2300
cd CMSSW_12_3_X_2022-04-06-2300/src
cmsenv
git-cms-merge-topic seungjin-yang:GEMEffByGEMCSCSegment__from-CMSSW_12_3_X_2022-04-06-2300
scram b -j4
cmsRun ${CMSSW_BASE}/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37341. I need a backport to 12_3_X for April collision runs

Backporting seungjin-yang:GEMEffByGEMCSCSegment__from-CMSSW_12_3_0_pre5 to CMSSW_12_3_X.
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

A new Pull Request was created by @seungjin-yang (Seungjin Yang) for CMSSW_12_3_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @watson-ij, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@seungjin-yang
Copy link
Contributor Author

@jshlee @quark2

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

please test

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

backport of #37178

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1184ba/23754/summary.html
COMMIT: 5fbcd24
CMSSW: CMSSW_12_3_X_2022-04-07-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37501/23754/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697381
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697351
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Apr 8, 2022

@cmsbuild cmsbuild merged commit a47cb2e into cms-sw:CMSSW_12_3_X Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants