memory leak fixes for Hydjets

[wouf]

PR description:

This is bugfix for #36316 . It fixes some bugs from here, including memory leak issues. Also in this PR, ED modules from the test/ folder were replaced.

PR validation:

Hydjet2 - wf 160
Hydjet - wf 150
Pyquen - wf 300

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37053/28496

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @wouf for master.

It involves the following packages:

• GeneratorInterface/Hydjet2Interface (generators)
• GeneratorInterface/HydjetInterface (generators)
• GeneratorInterface/PyquenInterface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @cbaus, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[SiewYan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a010d8/22643/summary.html
COMMIT: f95e1cc
CMSSW: CMSSW_12_3_X_2022-02-23-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37053/22643/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001119
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[SiewYan]

please test workflow 160, 150, 300

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a010d8/22691/summary.html
COMMIT: f95e1cc
CMSSW: CMSSW_12_3_X_2022-02-25-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37053/22691/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a010d8/160.0_Hydjet2Q_MinBias_5020GeV_2018_ppReco+Hydjet2Q_MinBias_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECOMB+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a010d8/300.0_Pyquen_GammaJet_pt20_2760GeV+Pyquen_GammaJet_pt20_2760GeV+DIGIHIMIX+RECOHIMIX+HARVESTHI2018PPRECO

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001113
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[SiewYan]

Thank you very much @wouf , I do not see the legacy module warning coming from the generator side. However, there are warning shown for others:

%MSG-s LegacyModules:  AfterModConstruction 26-Feb-2022 07:47:42 CET pre-events
The following legacy modules are configured. Support for legacy modules
is going to end soon. These modules need to be converted to have type
edm::global, edm::stream, edm::one, or in rare cases edm::limited.
  DQMHistNormalizer normalizePlotsZTT
  DQMFEDIntegrityClient dqmFEDIntegrity
  AlcaBeamMonitorClient AlcaBeamMonitorClient
  DQMMessageLoggerClient DQMMessageLoggerClient
  SiStripDaqInfo siStripDaqInfo
  ESDaqInfoTask ecalPreshowerDaqInfoTask
  SiStripDcsInfo siStripDcsInfo
  ESDcsInfoTask ecalPreshowerDcsInfoTask
  SiStripCertificationInfo siStripCertificationInfo
  ESDataCertificationTask ecalPreshowerDataCertificationTask
  EgHLTOfflineSummaryClient egHLTOffDQMSummaryClient
  DQMOfflineHLTEventInfoClient HLTOverallSummary

They will be taken care of by other group though.

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

this PR is a followup of #36918 : #36918 (comment) and #36316 (review)

[qliphy]

+1