Add the detector ids to the scouting electron and photon collection for Run 3 #36990

arsahasransu · 2022-02-17T13:12:47Z

PR description:

The Run 3 Scouting collection for electrons and photons will now have the ECal detector ids corresponding to the energy deposit and time stored earlier. This is done by adding a similar-sized vector of unsigned int datatype. The conversion from CMS datatype DetId to unsigned int is implicit.

PR validation:

This implementation has been cross-checked to correctly store all relevant information. The implicit conversion from DetId to unsigned int has also been verified. I re-ran the scouting path on a small set of events to ensure that there is no error in implementation and that the output that is of interest is stored.

The coding recommendations at http://cms-sw.github.io/cms_coding_rules.html were followed.
The basic test procedure was also successful.

cmsbuild · 2022-02-17T13:20:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36990/28378

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

cmsbuild · 2022-02-17T13:21:13Z

A new Pull Request was created by @arsahasransu (A.R.Sahasransu) for master.

It involves the following packages:

DataFormats/Scouting (core)
HLTrigger/Egamma (hlt)

@Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

missirol

Just a couple of comments from a first look.

HLTrigger/Egamma/plugins/HLTScoutingEgammaProducer.cc

DataFormats/Scouting/interface/Run3ScoutingElectron.h

DataFormats/Scouting/interface/Run3ScoutingPhoton.h

DataFormats/Scouting/src/classes_def.xml

cmsbuild · 2022-02-17T16:05:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36990/28384

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

cmsbuild · 2022-02-17T16:05:41Z

Pull request #36990 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

missirol · 2022-02-17T18:01:23Z

please test

cmsbuild · 2022-02-17T22:01:16Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b0091/22487/summary.html
COMMIT: 5f2405b
CMSSW: CMSSW_12_3_X_2022-02-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36990/22487/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

134.912134.912_RunZeroBias2015D+RunZeroBias2015D+HLTDR2_25ns+RECODR2_25nsreHLT_ZB_HIPM+HARVESTDR2ZB/step2_RunZeroBias2015D+RunZeroBias2015D+HLTDR2_25ns+RECODR2_25nsreHLT_ZB_HIPM+HARVESTDR2ZB.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b0091/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b0091/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0b0091/139.001_RunMinimumBias2021+RunMinimumBias2021+HLTDR3_2021+RECODR3_MinBiasOffline+HARVESTD2021MB

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3965113
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol · 2022-02-18T07:52:35Z

please test

I tested wf 134.912 locally (with this PR) and it passed, so I'm not sure what the issue was in #36990 (comment) (log here).

makortel · 2022-02-18T15:31:39Z

I'm not sure what the issue was in #36990 (comment) (log here).

The failure looks like xrootd timeout (although those shouldn't cause a crash though...)

missirol · 2022-02-18T19:34:33Z

please abort

(let's spare the bot for now)

Just to note that this (and below) [..]

@arsahasransu , right after the line you added, there are 2 other cases where .at(i) can be replaced with [i]. Please adjust those, too.

…llection

cmsbuild · 2022-02-18T23:13:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36990/28412

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/Scouting/src/classes_def.xml modified in PR(s): Using new Run3ScoutingHitPattern class for hitPattern in Run-3 scouting #35685

cmsbuild · 2022-02-18T23:13:28Z

Pull request #36990 was updated. @Martin-Grunewald, @Dr15Jones, @smuzaffar, @makortel, @cmsbuild, @missirol can you please check and sign again.

missirol · 2022-02-19T07:30:34Z

please test

cmsbuild · 2022-02-19T12:50:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b0091/22518/summary.html
COMMIT: 0cd224f
CMSSW: CMSSW_12_3_X_2022-02-18-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36990/22518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3965143
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3965119
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

missirol · 2022-02-19T13:25:02Z

+hlt

makortel · 2022-02-21T14:29:17Z

+core

cmsbuild · 2022-02-21T14:32:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-02-21T14:53:41Z

+1

cmsbuild added this to the CMSSW_12_3_X milestone Feb 17, 2022

cmsbuild added code-checks-pending core-pending hlt-pending orp-pending pending-signatures tests-pending labels Feb 17, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 17, 2022

missirol reviewed Feb 17, 2022

View reviewed changes

HLTrigger/Egamma/plugins/HLTScoutingEgammaProducer.cc Outdated Show resolved Hide resolved

DataFormats/Scouting/interface/Run3ScoutingElectron.h Outdated Show resolved Hide resolved

DataFormats/Scouting/interface/Run3ScoutingPhoton.h Outdated Show resolved Hide resolved

missirol reviewed Feb 17, 2022

View reviewed changes

DataFormats/Scouting/src/classes_def.xml Show resolved Hide resolved

arsahasransu force-pushed the addEcalDetIdsScouting branch from 51fcea6 to 5f2405b Compare February 17, 2022 15:57

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 17, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 17, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 17, 2022

cmsbuild added tests-rejected and removed tests-started labels Feb 17, 2022

cmsbuild added tests-started and removed tests-rejected labels Feb 18, 2022

cmsbuild added tests-pending and removed tests-started labels Feb 18, 2022

Commit to add the detector ids to the scouting electron and photon co…

0cd224f

…llection

arsahasransu force-pushed the addEcalDetIdsScouting branch from f111e6d to 0cd224f Compare February 18, 2022 23:06

cmsbuild added code-checks-pending and removed code-checks-approved labels Feb 18, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 18, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 19, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 19, 2022

cmsbuild added hlt-approved and removed hlt-pending labels Feb 19, 2022

cmsbuild added core-approved and removed core-pending pending-signatures labels Feb 21, 2022

cmsbuild added the fully-signed label Feb 21, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 21, 2022

cmsbuild merged commit 95eed0c into cms-sw:master Feb 21, 2022

Add the detector ids to the scouting electron and photon collection for Run 3 #36990

Add the detector ids to the scouting electron and photon collection for Run 3 #36990

Uh oh!

Conversation

arsahasransu commented Feb 17, 2022

PR description:

PR validation:

Uh oh!

cmsbuild commented Feb 17, 2022

Uh oh!

cmsbuild commented Feb 17, 2022

Uh oh!

missirol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cmsbuild commented Feb 17, 2022

Uh oh!

cmsbuild commented Feb 17, 2022

Uh oh!

missirol commented Feb 17, 2022

Uh oh!

cmsbuild commented Feb 17, 2022

RelVals-INPUT

Comparison Summary

Uh oh!

missirol commented Feb 18, 2022

Uh oh!

makortel commented Feb 18, 2022

Uh oh!

missirol commented Feb 18, 2022

Uh oh!

cmsbuild commented Feb 18, 2022

Uh oh!

cmsbuild commented Feb 18, 2022

Uh oh!

missirol commented Feb 19, 2022

Uh oh!

cmsbuild commented Feb 19, 2022

Comparison Summary

Uh oh!

missirol commented Feb 19, 2022

Uh oh!

makortel commented Feb 21, 2022

Uh oh!

cmsbuild commented Feb 21, 2022

Uh oh!

perrotta commented Feb 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants