Skip to content

Fix HPTDC timing PCL #36976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Feb 16, 2022
Merged

Fix HPTDC timing PCL #36976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84472ca
Fix EdmToMeConverter
Feb 15, 2022
62eaba7
Change to absolute paths, fix histogram type
Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLHarvester.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,19 +94,19 @@ void PPSTimingCalibrationPCLHarvester::dqmEndJob(DQMStore::IBooker& iBooker, DQM
const auto chid = detid.rawId();
const PPSTimingCalibration::Key key{
(int)detid.arm(), (int)detid.station(), (int)detid.plane(), (int)detid.channel()};
hists.leadingTime[chid] = iGetter.get("t_" + ch_name);
hists.leadingTime[chid] = iGetter.get(dqmDir_ + "/t_" + ch_name);
if (hists.leadingTime[chid] == nullptr) {
edm::LogInfo("PPSTimingCalibrationPCLHarvester:dqmEndJob")
<< "Failed to retrieve leading time monitor for channel (" << detid << ").";
continue;
}
hists.toT[chid] = iGetter.get("tot_" + ch_name);
hists.toT[chid] = iGetter.get(dqmDir_ + "/tot_" + ch_name);
if (hists.toT[chid] == nullptr) {
edm::LogInfo("PPSTimingCalibrationPCLHarvester:dqmEndJob")
<< "Failed to retrieve time over threshold monitor for channel (" << detid << ").";
continue;
}
hists.leadingTimeVsToT[chid] = iGetter.get("tvstot_" + ch_name);
hists.leadingTimeVsToT[chid] = iGetter.get(dqmDir_ + "/tvstot_" + ch_name);
if (hists.leadingTimeVsToT[chid] == nullptr) {
edm::LogInfo("PPSTimingCalibrationPCLHarvester:dqmEndJob")
<< "Failed to retrieve leading time vs. time over threshold monitor for channel (" << detid << ").";
Expand All @@ -120,7 +120,7 @@ void PPSTimingCalibrationPCLHarvester::dqmEndJob(DQMStore::IBooker& iBooker, DQM
}
const double upper_tot_range = hists.toT[chid]->getMean() + 2.5;
{ // scope for x-profile
std::unique_ptr<TProfile> prof(hists.leadingTimeVsToT[chid]->getTH2D()->ProfileX("_prof_x", 1, -1));
std::unique_ptr<TProfile> prof(hists.leadingTimeVsToT[chid]->getTH2F()->ProfileX("_prof_x", 1, -1));
interp_.SetParameters(hists.leadingTime[chid]->getRMS(),
hists.toT[chid]->getMean(),
0.8,
Expand Down
4 changes: 2 additions & 2 deletions CalibPPS/TimingCalibration/python/PPSTimingCalibrationHarvester_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
from DQMServices.Components.EDMtoMEConverter_cfi import EDMtoMEConverter

EDMtoMEConvertPPSTimingCalibration = EDMtoMEConverter.clone()
EDMtoMEConvertPPSTimingCalibration.lumiInputTag = cms.InputTag("EDMtoMEConvertPPSTimingCalibration", "MEtoEDMConverterLumi")
EDMtoMEConvertPPSTimingCalibration.runInputTag = cms.InputTag("EDMtoMEConvertPPSTimingCalibration", "MEtoEDMConverterRun")
EDMtoMEConvertPPSTimingCalibration.lumiInputTag = cms.InputTag("MEtoEDMConvertPPSTimingCalib", "MEtoEDMConverterLumi")
EDMtoMEConvertPPSTimingCalibration.runInputTag = cms.InputTag("MEtoEDMConvertPPSTimingCalib", "MEtoEDMConverterRun")


ALCAHARVESTPPSTimingCalibration = cms.Task(
Expand Down