Skip to content

Conversation

@tvami
Copy link
Contributor

@tvami tvami commented Feb 11, 2022

PR description:

Update Run-3 data and MC GTs with several updates

Data changes:

MC changes

The new GTs and their diffs

PR validation:

Wfs 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

We'll need a backport to 12_2_X

Resolves #36886

@tvami
Copy link
Contributor Author

tvami commented Feb 11, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0,138.4,138.5

@tvami
Copy link
Contributor Author

tvami commented Feb 11, 2022

urgent

  • we need this for pre5 (tests the conditions to be used in the 12_2_X MC)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36940/28280

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Feb 11, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Feb 11, 2022

I made an issue about the unit test failures,
#36944

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22366/summary.html
COMMIT: 9c28661
CMSSW: CMSSW_12_3_X_2022-02-11-1400/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36940/22366/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22366/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22366/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestDQMOnlineClient-ecal_dqm_sourceclient had ERRORS
---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 15772 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3764395
  • DQMHistoTests: Total failures: 14058
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3750315
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 7.296 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.912 KiB Physics/NanoAODDQM
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

@tvami
Copy link
Contributor Author

tvami commented Feb 12, 2022

@cmsbuild , please test with #36946

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22375/summary.html
COMMIT: 9c28661
CMSSW: CMSSW_12_3_X_2022-02-12-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36940/22375/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/138.5_ExpressCollisions+RunMinimumBias2021+TIER0EXPRUN3+ALCARECOEXPR3+HARVESTDEXPR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0f9c0d/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 15764 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3764435
  • DQMHistoTests: Total failures: 14064
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3750349
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

* CSC plots, are there just no plots that are sensitive to the bad chamber list?

@cms-sw/csc-dpg-l2 any insight here?

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0a27b06 into cms-sw:master Feb 13, 2022
@qliphy
Copy link
Contributor

qliphy commented Feb 14, 2022

@tvami There is an IB issue on wf 139.004 after this PR gets merged:

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_3_X_2022-02-13-2300/pyRelValMatrixLogs/run/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3/step2_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3.log#/

----- Begin Fatal Exception 14-Feb-2022 01:34:05 CET-----------------------
An exception of category 'NoRecord' occurred while
[0] Processing Event run: 346512 lumi: 250 event: 242720581 stream: 1
[1] Running path 'DST_Run3_PFScoutingPixelTracking_v16'
[2] Calling method for module HLTEcalRecHitInAllL1RegionsProducer/'hltRechitInRegionsECAL'
Exception Message:
No "L1CaloGeometryRecord" record found in the EventSetup.

@francescobrivio
Copy link
Contributor

francescobrivio commented Feb 14, 2022

@tvami There is an IB issue on wf 139.004 after this PR gets merged:

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc10/CMSSW_12_3_X_2022-02-13-2300/pyRelValMatrixLogs/run/139.004_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3/step2_RunNoBPTX2021+RunNoBPTX2021+HLTDR3_2021+RECODR3_AlCaTkCosmics_Offline+HARVESTDR3.log#/

----- Begin Fatal Exception 14-Feb-2022 01:34:05 CET----------------------- An exception of category 'NoRecord' occurred while [0] Processing Event run: 346512 lumi: 250 event: 242720581 stream: 1 [1] Running path 'DST_Run3_PFScoutingPixelTracking_v16' [2] Calling method for module HLTEcalRecHitInAllL1RegionsProducer/'hltRechitInRegionsECAL' Exception Message: No "L1CaloGeometryRecord" record found in the EventSetup.

This comes from step2 which uses the HLG GT:
cmsDriver.py step2 --process reHLT -s L1REPACK:Full,HLT:@relval2021 --conditions auto:run3_hlt --data --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3 -n 100
@cms-sw/hlt-l2 any hint how to configure properly HLTEcalRecHitInAllL1RegionsProducer not to use castor L1CaloGeometry for Run3?

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Feb 14, 2022

Nothing directly in the python config of the module instance refers to Castor directly. Maybe adding the missing record to the GT would help? The plugin does use a so-called l1InputRegions = cms.VPSet which may point to the fact that it needs to know the L1Calo Geometry (not just castor).

@francescobrivio
Copy link
Contributor

@Martin-Grunewald sorry you are right I meant the L1CaloGeometryRecord. The point of this PR is exactly to remove that (and Castor) from Run3 GTs since it's an old DDD tag which has not been been migrated to DD4HEP and we understood it was not used (see #36806) since the tag has not been updated since 2008.

@srimanob
Copy link
Contributor

OK, so now we have issue also L1Repack::Full. The test from #36806 (comment) shows that L1Repack does not work, but L1Repack::Full works. However, this is the question in L1 PR already on the need, i.e. it is still called for few modules. And also question on the stepchain which is strange to me.

@francescobrivio
Copy link
Contributor

I quickly run 139.004 with -s L1REPACK,HLT:@relval2021 (instead of -s L1REPACK:Full,HLT:@relval2021) and it works.
But i'm not entirely sure what the L1REPACK step does...

@missirol
Copy link
Contributor

any hint how to configure properly HLTEcalRecHitInAllL1RegionsProducer not to use castor L1CaloGeometry for Run3?

@francescobrivio

L1CaloGeometry is all over the producer in question, and is consumed here

: caloGeometryToken_{esConsumes()}, l1CaloGeometryToken_{esConsumes()} {

From a quick look at the producer, the L1CaloGeometry object is not really exploited when the parameters are those used in the HLT module that's crashing. Nevertheless, the plugin creates the L1CaloGeometry object regardless of config parameters, and various functions technically depend on it. So, it's probably true it is not needed, but I don't see a choice of parameters that allows to circumvent the issue, and this makes the update of this producer non-trivial (I can't guarantee it can be done for pre5).

input->getEtaPhiRegions(event, regions, l1CaloGeom);

I quickly run 139.004 with -s L1REPACK,HLT:@relval2021 (instead of -s L1REPACK:Full,HLT:@relval2021) and it works.

I'm missing something here. The error is from a module of the HLT step, so I don't see why it would go away with a change to the L1REPACK step.

@srimanob
Copy link
Contributor

Hi @missirol
Thanks for looking into it. I think the issue mixes with the observation mentioned in #36806 (comment). I think the conclusion, for now, is that it is still used in a few places and dropping it now can cause the issue.

@srimanob
Copy link
Contributor

OK, I've made tests based on 139.004 to cover on evidence we have seen.

===============================================================

L1REPACK:Full,HLT:@relval2021 ==> Reproduce the issue reported in IB
cmsDriver.py step2 --process reHLT -s L1REPACK:Full,HLT:@relval2021 --conditions auto:run3_hlt --data --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3 --io HLTDR3_2021.io --python HLTDR3_2021.py -n 100 --no_exec --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root
and also L1REPACK:Full,HLT:GRun

----- Begin Fatal Exception 14-Feb-2022 10:01:27 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 242720581 stream: 0
   [1] Running path 'DST_Run3_PFScoutingPixelTracking_v16'
   [2] Calling method for module HLTEcalRecHitInAllL1RegionsProducer/'hltRechitInRegionsECAL'
Exception Message:
No "L1CaloGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.

=================================================================
L1Repack only

With L1REPACK:Full, job runs fine.
cmsDriver.py step2 --process reHLT -s L1REPACK:Full --conditions auto:run3_hlt --data --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3 --io HLTDR3_2021.io --python L1REPACKFULL_2021.py -n 100 --no_exec --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root

With L1REPACK,
cmsDriver.py step2 --process reHLT -s L1REPACK --conditions auto:run3_hlt --data --eventcontent FEVTDEBUGHLT --datatier FEVTDEBUGHLT --era Run3 --io HLTDR3_2021.io --python L1REPACK_2021.py -n 100 --no_exec --filein filelist:step1_dasquery.log --lumiToProcess step1_lumiRanges.log --fileout file:step2.root

----- Begin Fatal Exception 14-Feb-2022 10:08:40 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243199235 stream: 0
   [1] Running path 'FEVTDEBUGHLToutput_step'
   [2] Prefetching for module PoolOutputModule/'FEVTDEBUGHLToutput'
   [3] Prefetching for module RawDataCollectorByLabel/'rawDataCollector'
   [4] Prefetching for module L1GTDigiToRaw/'l1GtPack'
   [5] Calling method for module L1GlobalTrigger/'simGtDigis'
Exception Message:
No "L1CaloGeometryRecord" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

=================================================================
It seems clear that L1PCalo is used in several places. I think it is maybe a choice to put in back, but keep the one w/o it also for future test and clean up. What do you think @cms-sw/alca-l2 ?

@francescobrivio
Copy link
Contributor

It seems clear that L1PCalo is used in several places. I think it is maybe a choice to put in back, but keep the one w/o it also for future test and clean up. What do you think @cms-sw/alca-l2 ?

We'll have a discussion at today's AlCaDB meeting (indico agenda), but it seems like the fastest/most straightforward solution for the moment is to include back the L1CaloGeometry tag.

@tvami
Copy link
Contributor Author

tvami commented Feb 14, 2022

@srimanob doesnt all of this mean that the config in the HLT-testing workflow should be changed?

@srimanob
Copy link
Contributor

@srimanob doesnt all of this mean that the config in the HLT-testing workflow should be changed?
Let's clarify with L1T in the meeting. I'm not sure too.

@tvami
Copy link
Contributor Author

tvami commented Feb 14, 2022

Tagging @bundocka

@tvami
Copy link
Contributor Author

tvami commented Feb 14, 2022

Let's discuss this further in #36806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EGM Run3 regression issue

8 participants