-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update Run-3 data and MC GTs with several updates #36940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
test parameters:
|
|
urgent
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36940/28280
|
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild , please test |
|
I made an issue about the unit test failures, |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-ecal_dqm_sourceclient had ERRORS ---> test TestDQMOnlineClient-hlt_dqm_sourceclient had ERRORS Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0f9c0d/22375/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
|
+alca
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/csc-dpg-l2 any insight here? |
|
+1 |
|
@tvami There is an IB issue on wf 139.004 after this PR gets merged: ----- Begin Fatal Exception 14-Feb-2022 01:34:05 CET----------------------- |
This comes from step2 which uses the HLG GT: |
|
Nothing directly in the python config of the module instance refers to Castor directly. Maybe adding the missing record to the GT would help? The plugin does use a so-called l1InputRegions = cms.VPSet which may point to the fact that it needs to know the L1Calo Geometry (not just castor). |
|
@Martin-Grunewald sorry you are right I meant the L1CaloGeometryRecord. The point of this PR is exactly to remove that (and Castor) from Run3 GTs since it's an old DDD tag which has not been been migrated to DD4HEP and we understood it was not used (see #36806) since the tag has not been updated since 2008. |
|
OK, so now we have issue also L1Repack::Full. The test from #36806 (comment) shows that L1Repack does not work, but L1Repack::Full works. However, this is the question in L1 PR already on the need, i.e. it is still called for few modules. And also question on the stepchain which is strange to me. |
|
I quickly run 139.004 with |
From a quick look at the producer, the
I'm missing something here. The error is from a module of the HLT step, so I don't see why it would go away with a change to the L1REPACK step. |
|
Hi @missirol |
|
OK, I've made tests based on 139.004 to cover on evidence we have seen. =============================================================== L1REPACK:Full,HLT:@relval2021 ==> Reproduce the issue reported in IB ================================================================= With L1REPACK:Full, job runs fine. With L1REPACK, ================================================================= |
We'll have a discussion at today's AlCaDB meeting (indico agenda), but it seems like the fastest/most straightforward solution for the moment is to include back the L1CaloGeometry tag. |
|
@srimanob doesnt all of this mean that the config in the HLT-testing workflow should be changed? |
|
|
Tagging @bundocka |
|
Let's discuss this further in #36806 |
PR description:
Update Run-3 data and MC GTs with several updates
Data changes:
MC changes
The new GTs and their diffs
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_v1/123X_dataRun3_HLT_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_Express_v1/123X_dataRun3_Express_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_Prompt_v1/123X_dataRun3_Prompt_v2
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_design_v5/123X_mcRun3_2021_design_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_v5/123X_mcRun3_2021_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021cosmics_realistic_deco_v5/123X_mcRun3_2021cosmics_realistic_deco_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2021_realistic_HI_v5/123X_mcRun3_2021_realistic_HI_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2023_realistic_v5/123X_mcRun3_2023_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun3_2024_realistic_v5/123X_mcRun3_2024_realistic_v6
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_mcRun4_realistic_v3/123X_mcRun4_realistic_v4
PR validation:
Wfs 12034.0,11634.0,7.23,159.0,12434.0,12834.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
We'll need a backport to 12_2_X
Resolves #36886