Skip to content

Conversation

@nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Feb 4, 2022

This PR lowers the pT cut on AK4 Puppi jets (slimmedJetsPuppi) from 15 GeV to 10 GeV in Run 3 MiniAODs, same pT cut value as AK4 CHS jets (slimmedJets).

  • Event size increases by about 0.37%. The size comparison tests were performed with 5000 events from a UL18 TTJets AODSIM file.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36890/28161

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2022

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Feb 7, 2022

assign xpog

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

New categories assigned: xpog

@mariadalfonso,@gouskos,@fgolf you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jpata
Copy link
Contributor

jpata commented Feb 7, 2022

assign @cms-sw/jetmet-pog-l2

cc @laurenhay

@jpata
Copy link
Contributor

jpata commented Feb 7, 2022

Has this already been presented and discused at JME? What's the motivation for the change?

@nurfikri89
Copy link
Contributor Author

nurfikri89 commented Feb 7, 2022

@jpata This was discussed in last week’s XPOG meeting in the context of switching AK4 CHS to AK4 Puppi jets in Run 3 NanoAODs. The minimum pT of AK4 (currently CHS) jets stored in NanoAOD is 15 GeV. Since AK4 CHS jets are stored with pT > 10 GeV in MiniAODs, we would like to lower the pT threshold of AK4 Puppi jets to the same value.

@mariadalfonso
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4a506/22258/summary.html
COMMIT: bdafbae
CMSSW: CMSSW_12_3_X_2022-02-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36890/22258/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 158.01158.01_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD/step2_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD.log
  • 312.0312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/step3_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO.log

RelVals-INPUT

  • 140.5611140.5611_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD/step2_RunHI2018AOD+RunHI2018AOD+REMINIAODHID18+HARVESTHI18MINIAOD.log
  • 158.01158.01_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD/step2_HydjetQ_reminiaodPbPb2018_INPUT+HydjetQ_reminiaodPbPb2018_INPUT+REMINIAODHI2018PPRECOMB+HARVESTHI2018PPRECOMINIAOD.log

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36890/28198

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36890/28719

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

Pull request #36890 was updated. @gouskos, @clacaputo, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please check and sign again.

@gouskos
Copy link
Contributor

gouskos commented Mar 7, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4a506/22905/summary.html
COMMIT: e648467
CMSSW: CMSSW_12_3_X_2022-03-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36890/22905/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1198 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3984447
  • DQMHistoTests: Total failures: 349
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3984076
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

threshold of AK4puppi is set to 10 GeV

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2022

+1

@cmsbuild cmsbuild merged commit 5a14f18 into cms-sw:master Mar 8, 2022
@nurfikri89 nurfikri89 deleted the from1230pre4_AK4PuppiLowerPtInMini branch October 18, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants