fix handling of nano steps in Patatrack workflows

[kpedro88]

PR description:

This fixes an unexpected interaction between the existing Patatrack workflow setup and the new Run3 reco/harvest+nano combined steps (reported in #36167 (comment)).

PR validation:

Checked that missing steps reappeared in output of runTheMatrix.py -w gpu -l 11634.506 --dryRun. This also affects 11634.505, which is a CPU workflow in the regular matrix, so it can be used for testing this PR more easily.

[kpedro88]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36309/27047

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

• Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @missirol, @slomeo, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

test parameters:
workflow = 11634.505

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af1131/20896/summary.html
COMMIT: c055434
CMSSW: CMSSW_12_2_X_2021-11-30-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36309/20896/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-af1131/11634.505_TTbar_14TeV+2021_Patatrack_PixelOnlyTripletsCPU+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3042214
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3042192
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 40 files compared)
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[fwyzard]

Trying to understand what happened: the Reco step has been changed to RecoNano for Run-3 etc., and thus was being filtered out by the "Nano" in skip check ?

[kpedro88]

Yes, that's correct.

[srimanob]

+Upgrade

Technical PR to fix the Patatrack workflow.

[perrotta]

@cms-sw/pdmv-l2 this fix should be included in pre3: could you please have a look and sign, if you think so?

[bbilin]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

@kpedro88 I see issues with nano wfs in the IB RelVals after this PR was merged:
https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_12_2/2021-12-02-1100?selectedArchs=slc7_amd64_gcc900&selectedFlavors=X&selectedStatus=failed

Can you please have a look?

[kpedro88]

@perrotta aha, the 2018 workflows were not tested in this PR... see #36341 for a better fix